Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli - fix gpspassthrouh when GPS port is not open #13878

Merged
merged 1 commit into from
Sep 6, 2024
Merged

cli - fix gpspassthrouh when GPS port is not open #13878

merged 1 commit into from
Sep 6, 2024

Conversation

ledvinap
Copy link
Contributor

@ledvinap ledvinap commented Sep 5, 2024

  • return status from gpsPassthrough
  • test gpsPort

@ledvinap
cli - fix gpspassthrouh when GPS port is not open
15234bb 
- return status from gpsPassthrough
- test gpsPort
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024

Do you want to test this code? You can flash it directly from Betaflight Configurator:

  • Simply put #13878 (this pull request number) in the Select commit field of the Configurator firmware flasher tab (you need to Enable expert mode, Show release candidates and Development).

WARNING: It may be unstable. Use only for testing!

@ledvinap ledvinap mentioned this pull request Sep 5, 2024
Closed
@haslinghuis haslinghuis added this to the 4.6 milestone Sep 5, 2024
@haslinghuis haslinghuis linked an issue Sep 5, 2024 that may be closed by this pull request
Null Deref in CLI gpspassthrough #13700
Closed
ctzsnooze
ctzsnooze approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@ctzsnooze ctzsnooze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't use this feature but happy to approve since it looks appropriate.

@haslinghuis haslinghuis merged commit 952ccb6 into betaflight:master Sep 6, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

@ctzsnooze ctzsnooze ctzsnooze approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

@blckmn blckmn Awaiting requested review from blckmn

@KarateBrot KarateBrot Awaiting requested review from KarateBrot

Assignees

@ledvinap ledvinap

Labels
RN: BUGFIX
Projects
Finalizing Firmware 4.6 Release
Status: Done
Milestone
4.6
Development

Successfully merging this pull request may close these issues.

Null Deref in CLI gpspassthrough
4 participants
@ledvinap @haslinghuis @ctzsnooze @nerdCopter