Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add level angle limit #473

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Conversation

klutvott123
Copy link
Member

and stick sensitivity

@klutvott123 klutvott123 added this to the 1.8 milestone Mar 5, 2023
@klutvott123 klutvott123 self-assigned this Mar 5, 2023
Comment on lines +17 to +19
if apiVersion < 1.36 then
fields[#fields + 1] = { t = "Stick Sensitivity", x = x + indent, y = inc.y(lineSpacing), sp = x + sp, min = 10, max = 200, vals = { 19 } }
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We removed support for 1.41 and below.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I mean we removed support for API 1.41 and below in general as we did in configurator assuming

if apiVersion >= 1.31 then 

would always be valid and no longer needed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still possible to use the lua scripts with older firmware versions, so no, it won't always be valid. Conditionals like this also serve as documentation.
I don't think we should limit backwards compatibility in the lua scripts as long as it's not a maintenance nightmare. 🙂

@haslinghuis haslinghuis merged commit 6676a11 into betaflight:master Mar 6, 2023
@klutvott123 klutvott123 deleted the level-limit branch March 6, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

2 participants