Skip to content

Commit

Permalink
Fix intermittent test failure in 80-test_cmp_http.t
Browse files Browse the repository at this point in the history
output to stderr is unbuffered bypassing the normal output, which does
not happen at line boundaries and is therefore confusing the TAP parser.
This is known to cause random test failures like this one:

80-test_cmp_http.t                    (Wstat: 0 Tests: 5 Failed: 0)
  Parse errors: Tests out of sequence.  Found (6) but expected (5)
                Bad plan.  You planned 6 tests but ran 5.

Fixes openssl#23992
  • Loading branch information
bernd-edlinger committed Jan 9, 2025
1 parent 6a2472f commit ccf3903
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/recipes/80-test_cmp_http.t
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ sub start_server {
$args ? $args : ()]), display => 1);
print "Current directory is ".getcwd()."\n";
print "Launching $server_name server: $cmd\n";
my $pid = open($server_fh, "$cmd|");
my $pid = open($server_fh, "$cmd 2>&1 |");
unless ($pid) {
print "Error launching $cmd, cannot obtain $server_name server PID";
return 0;
Expand Down

0 comments on commit ccf3903

Please sign in to comment.