Require a Berksfile for the #info command #563
Conversation
| @@ -346,20 +346,23 @@ def show(name) | |||
| Berkshelf.formatter.msg(cookbook.path) | |||
| end | |||
|
|
|||
| method_option :version, | |||
| method_option :berksfile, | |||
There was a problem hiding this comment.
We talked about this one today. We shouldn't require a Berksfile for the info command and we shouldn't resolve
There was a problem hiding this comment.
...? I thought the resolution was the exact opposite, as I have it here. We discussed adding a berks shelf info which would behave the way this command currently functions. This differs from the behavior of list, which is confusing to the user. Did I misunderstand this today? I thought we agreed that everything should operate on a Berksfile. @ivey?
There was a problem hiding this comment.
I agree, both with the PR and that that was the resolution Sunday.
|
Failure is due to an aruba timeout error |
|
@reset now that we have |
| # | ||
| # @param [CachedCookbook] cookbook | ||
| def info(cookbook) | ||
| cookbooks[cookbook.cookbook_name] ||= {} |
There was a problem hiding this comment.
Should this be cookbooks ||= {}?
There was a problem hiding this comment.
Nope, this line should be gone entirely.
There was a problem hiding this comment.
@ivey this is fixed. Nice catch!
|
👍 after the unnecessary |
|
@ivey fixed those concerns and rebased |
|
I don't understand this build failure, and I can't reproduce locally on the same version of Ruby 1.9.2 |
Require a Berksfile for the #info command
Also includes:
#pretty_hashand#pretty_jsonmethod forCachedCookbooks