Search for the knife.rb like chef does

[sethvargo]

See: #382

[sethvargo]

@reset @schisamo, added specs

[schisamo]

Shouldn't this be something like:

candidate_directory = File.join(file.expand_path, '.chef')
if File.exist?(candidate_directory) && File.directory?(candidate_directory)
  possibles << File.join(candidate_directory, 'knife.rb')
end

[sethvargo]

I'm pretty sure it's fundamentally the same, no?

Search upward and add anything that is .chef. I could add the directory? check, but the actual existence check is done later at line ~45.

[sethvargo]

I added the directory check in 0b8005a

[schisamo]

The directory check wasn't my concern, I'm confused on how this code:

Pathname.new(working_dir).ascend do |file|
  possibles << file.expand_path if file.basename == '.chef' && file.directory?
end

will ever actually get a .chef directory. For example:

 % irb
irb(main):001:0> require 'pathname'
=> true
irb(main):002:0> p = Pathname.new(Dir.pwd)
=> #<Pathname:/Users/schisamo/dev/code/opscode-cookbooks/opscode-ci>
irb(main):003:0> p.ascend{ |file| puts "Path = #{file}, Basename = #{file.basename}" }
Path = /Users/schisamo/dev/code/opscode-cookbooks/opscode-ci, Basename = opscode-ci
Path = /Users/schisamo/dev/code/opscode-cookbooks, Basename = opscode-cookbooks
Path = /Users/schisamo/dev/code, Basename = code
Path = /Users/schisamo/dev, Basename = dev
Path = /Users/schisamo, Basename = schisamo
Path = /Users, Basename = Users
Path = /, Basename = /
=> nil

[sethvargo]

You're right. I just realized this in refactoring my tests. Push coming soon 😄

[sethvargo]

@schisamo re-review please when you have a chance?

[ivey]

Are we merging this, or moving to a new gem?

[sethvargo]

I'm indifferent. @reset?

[reset]

We should merge it in and then refactor it if at anytime a gem exists which replicates the functionality