Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional config options for berks cookbook create #151

Closed
reset opened this issue Oct 10, 2012 · 2 comments
Closed

Additional config options for berks cookbook create #151

reset opened this issue Oct 10, 2012 · 2 comments
Milestone

Comments

@reset
Copy link
Contributor

reset commented Oct 10, 2012

Additional flags should be provided to the berks cookbook create command that will configure the generated Vagrantfile. The fields in the Vagrantfile which should be configurable are:

  • config.vm.host_name
  • config.vm.box
  • config.vm.network
  • chef.chef_server_url
  • chef.validation_client_name
  • chef.validation_key_path
@justincampbell
Copy link
Contributor

@reset What do you think about getting rid of the command line options now that there's a config option?

Also maybe we should add a config generator to get people started...

justincampbell added a commit that referenced this issue Oct 24, 2012
Generates a default config.json

[#151]
@reset
Copy link
Contributor Author

reset commented Oct 24, 2012

@justincampbell I think it's a good approach to remove the flags if there is a config option.

Somebody might want to override their config options with these flags but theres also something to be said about apps that have a million flags...

justincampbell added a commit that referenced this issue Oct 25, 2012
@berkshelf berkshelf locked and limited conversation to collaborators Jun 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants