Skip to content

Commit

Permalink
gcp: rename gcp-zone to region
Browse files Browse the repository at this point in the history
Following the previous commits, updated GCP zone naming for consistency:

AWS:   -aws-region
Azure: -region
GCP:   -zone

GCP is using zones instead of regions, since IBM is also without prefix,
I'm joing the non-prefix team here.

Signed-off-by: Beraldo Leal <bleal@redhat.com>
  • Loading branch information
beraldoleal committed Feb 5, 2025
1 parent 9fb32e0 commit dead36c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/cloud-api-adaptor/entrypoint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ gcp() {

[[ "${PODVM_IMAGE_NAME}" ]] && optionals+="-image-name ${PODVM_IMAGE_NAME} "
[[ "${GCP_PROJECT_ID}" ]] && optionals+="-gcp-project-id ${GCP_PROJECT_ID} "
[[ "${GCP_ZONE}" ]] && optionals+="-gcp-zone ${GCP_ZONE} " # if not set retrieved from IMDS
[[ "${GCP_ZONE}" ]] && optionals+="-zone ${GCP_ZONE} " # if not set retrieved from IMDS
[[ "${GCP_MACHINE_TYPE}" ]] && optionals+="-machine-type ${GCP_MACHINE_TYPE} " # default e2-medium
[[ "${GCP_NETWORK}" ]] && optionals+="-network ${GCP_NETWORK} " # defaults to 'default'

Expand Down
2 changes: 1 addition & 1 deletion src/cloud-providers/gcp/manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ func (_ *Manager) ParseCmd(flags *flag.FlagSet) {

flags.StringVar(&gcpcfg.GcpCredentials, "gcp-credentials", "", "Google Application Credentials, defaults to `GCP_CREDENTIALS`")
flags.StringVar(&gcpcfg.ProjectId, "gcp-project-id", "", "GCP Project ID")
flags.StringVar(&gcpcfg.Zone, "gcp-zone", "", "Zone")
flags.StringVar(&gcpcfg.Zone, "zone", "", "Zone")
flags.StringVar(&gcpcfg.ImageName, "image-name", "", "Pod VM image name")
flags.StringVar(&gcpcfg.MachineType, "machine-type", "e2-medium", "Pod VM instance type")
flags.StringVar(&gcpcfg.Network, "network", "", "Network ID to be used for the Pod VMs")
Expand Down

0 comments on commit dead36c

Please sign in to comment.