Do not emit backlog metric if its unsupported

benoitc · Nov 14, 2023 · 9e308f5 · 9e308f5
1 parent b980c0d
commit 9e308f5
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/gunicorn/arbiter.py b/gunicorn/arbiter.py
@@ -584,7 +584,11 @@ def manage_workers(self):
                                   "value": active_worker_count,
                                   "mtype": "gauge"})
 
-        backlog = sum([sock.get_backlog() for sock in self.LISTENERS])
+        backlog = sum([
+            sock.get_backlog()
+            for sock in self.LISTENERS
+                if sock.get_backlog() is not None
+        ])
         if backlog:
             self.log.debug("socket backlog: {0}".format(backlog),
                            extra={"metric": "gunicorn.backlog",

diff --git a/gunicorn/sock.py b/gunicorn/sock.py
@@ -74,7 +74,7 @@ def close(self):
         self.sock = None
 
     def get_backlog(self):
-        return 0
+        return None
 
 
 class TCPSocket(BaseSocket):
@@ -100,12 +100,14 @@ def get_backlog(self):
             fmt = 'B'*8+'I'*24
             try:
                 tcp_info_struct = self.sock.getsockopt(socket.IPPROTO_TCP,
-                                                      socket.TCP_INFO, 104)
+                                                       socket.TCP_INFO, 104)
                 # 12 is tcpi_unacked
                 return struct.unpack(fmt, tcp_info_struct)[12]
             except AttributeError:
                 pass
-        return 0
+
+        return None
+
 
 class TCP6Socket(TCPSocket):