Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vite defines conditions when bundling and the fallback is only hit when not bundling, so the
import.meta.env.DEV
doesn't do anything and can be removedConditions should be set during bundling. We can update
rollup-plugin-svelte
andsvelte-loader
to enforce that they are. Users should always have one of eitherdevelopment
orproduction
set. If neither are set, then we know something is wrong. We also know something is wrong in the svelte plugins if the thesvelte
condition doesn't get setThe fallbacks can't be tree-shaken, but can only be hit when not bundling in which case we don't need tree-shaking anyway