Fix lines test so line endings don't get in the way on windows #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamn
added a commit
that referenced
this pull request
Feb 11, 2018
Instead of using arguments.callee (which is not available in strict mode), this implementation relies on naming the anonymous test functions whose code we want to use in the corresponding test. The check function has been improved to join Lines objects using the proper end-of-line terminator, as an alternative to #460.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #459
Instead of using arguments.callee to create a fixture, hardcodes one that properly uses the operating system's eol (which is Recast's behavior, and rightly so).
I'm not 100% sure exactly what the original tests were looking for in the current function to test, but I tried to make fixtures that had similar properties.