add getKey and forgetKey API (#188) #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brainkim here is the PR per our conversation. |
benjamn
approved these changes
May 8, 2021
There was a problem hiding this comment.
Regardless of how we use these APIs in the short term, I think it's worthwhile to have -Key versions of each of the functions attached to the optimistic wrapper function. I kept your getKey and forgetKey functions, but added dirtyKey and peekKey, along with exposing the makeCacheKey function in case folks need it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the conversation in apollographql/apollo-feature-requests#289, add
getKey&forgetKeyAPI's toOptimisticWrapperFunction.The motive here is to keep track of the cached entries without having to memoize the arguments and duplicate the logic for weakly tracking them. This will enable the creators of
OptimisticWrapperFunctionto use the true keys for removing entries via theforgetKeyAPI.