Lint fixes.

.golangci.yml

@@ -0,0 +1,37 @@
+# gci write ./..
+# gofumpt -w .
+# golangci-lint run
+
+linters:
+  enable-all: true
+  disable:
+    # deprecated
+    - ifshort
+    - interfacer
+    - structcheck
+    - nosnakecase
+    - deadcode
+    - exhaustivestruct
+    - golint
+    - scopelint
+    - maligned
+    - varcheck
+    # opinionated
+    - depguard
+    - nlreturn
+    - paralleltest
+    - varnamelen
+    - wrapcheck
+    - wsl
+
+linters-settings:
+  cyclop:
+    max-complexity: 15
+
+issues:
+  exclude-rules:
+    # all test files
+    - path: '(.+)_test\.go'
+      linters:
+        - exhaustruct
+        - lll

bbs.go

@@ -507,9 +507,8 @@ func (b BBS) Remove(dst *bytes.Buffer, src []byte) error {
 		return remove(dst, src, WWIVHashRe)
 	case WWIVHeart:
 		return remove(dst, src, WWIVHeartRe)
-	default:
-		return ErrNone
 	}
+	return ErrNone
 }
 
 func remove(dst *bytes.Buffer, src []byte, expr string) error {

example_test.go

@@ -24,14 +24,16 @@ func Example() {
 
 	s, b, err := bbs.Fields(file)
 	if err != nil {
-		log.Fatal(err)
+		log.Print(err)
+		return
 	}
 	fmt.Printf("Found %d %s color controls.\n\n", len(s), b)
 
 	// reopen the file
 	file, err = static.Open("static/examples/hello.pcb")
 	if err != nil {
-		log.Fatal(err)
+		log.Print(err)
+		return
 	}
 	defer file.Close()
 
@@ -42,7 +44,8 @@ func Example() {
 	// create the HTML equivalent of BBS color codes
 	var buf bytes.Buffer
 	if _, err := bbs.HTML(&buf, reader); err != nil {
-		log.Fatal(err)
+		log.Print(err)
+		return
 	}
 	fmt.Print(buf.String())
 

examplebbs_test.go

@@ -136,9 +136,9 @@ func ExampleBBS_CSS() {
 	//
 	// /* PCBoard and WildCat! BBS colours */
 	//
-	//i.PF0 {
+	// i.PF0 {
 	//     color: var(--black);
-	//}
+	// }
 }
 
 func ExampleBBS_HTML() {

internal/split/split.go

@@ -10,9 +10,7 @@ import (
 	"strings"
 )
 
-var (
-	ErrBuff = errors.New("bytes buffer cannot be nil")
-)
+var ErrBuff = errors.New("bytes buffer cannot be nil")
 
 // colorInt template data for integer based color codes.
 type colorInt struct {
@@ -75,7 +73,11 @@ func VBarsHTML(dst *bytes.Buffer, src []byte) error {
 		return err
 	}
 
-	d := colorInt{}
+	d := colorInt{
+		Foreground: -1,
+		Background: -1,
+		Content:    "",
+	}
 	bars := VBars(src)
 	if len(bars) == 0 {
 		_, err := dst.Write(src)
@@ -102,20 +104,22 @@ func VBarsHTML(dst *bytes.Buffer, src []byte) error {
 }
 
 func barBackground(n int) bool {
-	if n < 16 {
+	const first, last = 16, 23
+	if n < first {
 		return false
 	}
-	if n > 23 {
+	if n > last {
 		return false
 	}
 	return true
 }
 
 func barForeground(n int) bool {
-	if n < 0 {
+	const first, last = 0, 15
+	if n < first {
 		return false
 	}
-	if n > 15 {
+	if n > last {
 		return false
 	}
 	return true
@@ -162,6 +166,7 @@ func CelerityHTML(dst *bytes.Buffer, src []byte) error {
 	d := colorStr{
 		Foreground: "w",
 		Background: "k",
+		Content:    "",
 	}
 
 	bars := Celerity(src)
@@ -224,7 +229,11 @@ func PCBoardHTML(dst *bytes.Buffer, src []byte) error {
 		return err
 	}
 
-	d := colorStr{}
+	d := colorStr{
+		Foreground: "",
+		Background: "",
+		Content:    "",
+	}
 	xcodes := PCBoard(src)
 	if len(xcodes) == 0 {
 		_, err := dst.Write(src)

internal/split/split_test.go

@@ -3,6 +3,7 @@ package split_test
 import (
 	"bytes"
 	"fmt"
+	"os"
 	"testing"
 
 	"github.com/bengarrett/bbs/internal/split"
@@ -27,7 +28,7 @@ func Test_VBars(t *testing.T) {
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			if got := len(split.VBars([]byte(tt.args.s))); got != tt.want {
-				fmt.Println(split.VBars([]byte(tt.args.s)))
+				fmt.Fprintln(os.Stderr, split.VBars([]byte(tt.args.s)))
 				t.Errorf("VBars() = %v, want %v", got, tt.want)
 			}
 		})
@@ -54,7 +55,7 @@ func Test_Celerity(t *testing.T) {
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			if got := len(split.Celerity([]byte(tt.args.s))); got != tt.want {
-				fmt.Println(split.Celerity([]byte(tt.args.s)))
+				fmt.Fprintln(os.Stderr, split.Celerity([]byte(tt.args.s)))
 				t.Errorf("Celerity() = %v, want %v", got, tt.want)
 			}
 		})
@@ -80,7 +81,7 @@ func Test_PCBoard(t *testing.T) {
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			if got := len(split.PCBoard([]byte(tt.args.s))); got != tt.want {
-				fmt.Println(split.PCBoard([]byte(tt.args.s)))
+				fmt.Fprintln(os.Stderr, split.PCBoard([]byte(tt.args.s)))
 				t.Errorf("PCBoard() = %v, want %v", got, tt.want)
 			}
 		})