Fix mutable default robot object #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caused interference between the training environment and the evaluation environment, if you use stable-baselines3 (where they did the training and evaluation implementation RIGHT)
|
Oh well, mutable default parameters...Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bulletphysics/bullet3#2352 : Fixes this problem.
The mutable robot object instance in the default init parameter caused the default robot object to be shared between multiple instances of environments.
For example, if you use stable-baselines3 (where they did the training and evaluation implementation RIGHT),
they have separate train and eval environment instantiated and the robot gets shared between the two.