new format option: elapsed #89
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves a case where I have a value in seconds but need HH:MM displayed. The specific case is time_remaining attribute on a sprinkler zone.
|
Looks good 👍 I'll try to merge this in when I get the time to bump a new version. |
benct
added a commit
that referenced
this pull request
Oct 9, 2020
|
I ended up with implementing this slightly differently, using the same seconds-to-duration calculation and format as the HA frontend. Also, the option is now called Thanks for your contribution! |
|
Thanks! I checked the latest version with "duration" and it appears to be working correctly. I didn't know about the secondsToDuration() method. That's much simpler than what I had. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves a case where I have a value in seconds but need HH:MM displayed. The specific case is time_remaining attribute on a sprinkler zone.
I was going to revise the readme.md too, but for some reason GitHub keeps blanking the entire view when I try to edit it. I guess you'll have to update that if you merge my change.