Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update computeStateDisplay to support new translation_key #293

Merged
merged 1 commit into from
May 30, 2023
Merged

Update computeStateDisplay to support new translation_key #293

merged 1 commit into from
May 30, 2023

Conversation

mill1000
Copy link
Contributor

Close #292, #290, and maybe #289

@jeremywillans
Copy link

@benct, can you please review this PR ?

@kukulich
Copy link

@mill1000 Is it possible to support translated attribute values as well?

@mill1000
Copy link
Contributor Author

mill1000 commented May 2, 2023

Yes it's possible but likely best for a separate PR. It would need to implement something like computeAttributeValueDisplay

@iankaufmann
Copy link

While waiting for an official update, I have tried to replace my local "multiple-entity-row.js" file with the one from this pull request.

I've chosen "Reload Resources" from the menu, and cleared cache.

Doesn't seem to change how things are displayed. Still says "off" and "on" instead of "Closed" and "Open".

Is there something I'm missing to make this work?

@mill1000
Copy link
Contributor Author

mill1000 commented May 6, 2023

What if you gzip multiple-entity-row.js? e.g. gzip multiple-entity-row.js

@iankaufmann
Copy link

What if you gzip multiple-entity-row.js? e.g. gzip multiple-entity-row.js

Interesting, I was wondering what was up with the .gz file. That worked! Makes sense now.

Thank you!

@GRClark
Copy link

GRClark commented May 20, 2023

Any update on this? I’m unfamiliar with how long the role was takes for pull requests to become published updates but eager to have this fixed so that I can once again upgrade HA.

@wigster
Copy link

wigster commented May 23, 2023

Unfortunately it seems there is no activity from @benct on GitHub since Dec 22.

@kukulich
Copy link

#291 (comment)

@GRClark
Copy link

GRClark commented May 23, 2023

Does anyone know how to take these files and use them? I saw the gzip comment @mill1000 and @iankaufmann made and confused by it. Not familiar with how to do that. Using Home Assistant IN Docker environment.

@jeremywillans
Copy link

@GRClark, replace/overwrite the .js file and delete the gzip from the directory - once you refresh your browser/cache, the updated values should show. for the mobile app, open the settings and select the reload frontend cache option.

@mill1000
Copy link
Contributor Author

Those looking for an easier solution can add my fork (mill1000/lovelace-multiple-entity-row) as a custom repository under HACS.

image

@benct benct merged commit 0b08c72 into benct:master May 30, 2023
benct added a commit that referenced this pull request May 30, 2023
@mill1000
Copy link
Contributor Author

@benct Thanks Ben!

@mill1000 mill1000 deleted the issue/compute_state_display branch May 30, 2023 14:04
@benct
Copy link
Owner

benct commented May 30, 2023

Released in version 4.5.0. I'm not myself on HA 2023.4 or later yet, so please let me know if it works as expected.

@d3relict
Copy link

updated, works as expected on Home Assistant 2023.5.3, Frontend 20230503.3 - latest
thanks to all of you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As of 2023.4.3 the m-e-row shows status of people as raw home/not_home instead of Home/Away
8 participants