Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format floating point hours as time duration: Update entity.js #263

Merged
merged 1 commit into from
May 30, 2023

Conversation

FragMenthor
Copy link
Contributor

Option to format floating point hours, from history-stats for instance, as time duration.
Syntax:
format: duration-h

@FragMenthor FragMenthor changed the title Update entity.js Format floating point hours as time duration Aug 23, 2022
@FragMenthor FragMenthor changed the title Format floating point hours as time duration Format floating point hours as time duration: Update entity.js Aug 23, 2022
@matthewhadley
Copy link

@benct any chance of merging this PR? It would seem to resolve #250

@jumping2000
Copy link

Option to format floating point hours, from history-stats for instance, as time duration. Syntax: format: duration-h

hello, do you have in your repo a working lovelace-entity-row card with this improvments?
thanks

@FragMenthor
Copy link
Contributor Author

Unfortunately I don't, I would prefer the author to review and aprove, I don't have knowledge of compilation in GitHub, and not 100% sure it works as expected. But still need this...

@jumping2000
Copy link

jumping2000 commented Apr 12, 2023

Unfortunately I don't, I would prefer the author to review and aprove, I don't have knowledge of compilation in GitHub, and not 100% sure it works as expected. But still need this...

This repo has no commits since 12/2021, and the ownersappears to be ignoring all issues raised and all PRs submitted. it appears abandoned

@FragMenthor
Copy link
Contributor Author

I am going to mention here @carlos-sarmiento, and ask for help, because it seems you where the last one to implement changes on a fork, and since I don't know how to do that, maybe you could see my changes, they are very small, test and compile, please? Thanks in advance!

@carlos-sarmiento
Copy link
Contributor

Hey @FragMenthor, if you want you can submit your PR to my repo and I can review it and merge it there

@benct benct merged commit 0cfc0a3 into benct:master May 30, 2023
@ildar170975
Copy link

ildar170975 commented May 30, 2023

A corresponding change in readme is expected.
Update: missed #264, sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants