Django 2.0 support (#4)

* Add requirements for Django 2.0 * Prepare notes for django 2.o * Changed a thing * Had some jokers from the distant past come in and review
bellhops · Dec 5, 2018 · 55238a2 · 55238a2
1 parent 805ac89
commit 55238a2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/notes/migrations/0001_initial.py b/notes/migrations/0001_initial.py
@@ -4,6 +4,7 @@
 from django.db import models, migrations
 import django.utils.timezone
 from django.conf import settings
+import django.db.models.deletion
 
 
 class Migration(migrations.Migration):
@@ -23,8 +24,8 @@ class Migration(migrations.Migration):
                 ('content', models.TextField(verbose_name='Content')),
                 ('public', models.BooleanField(default=True, verbose_name='Public')),
                 ('object_id', models.PositiveIntegerField()),
-                ('author', models.ForeignKey(blank=True, to=settings.AUTH_USER_MODEL, null=True)),
-                ('content_type', models.ForeignKey(to='contenttypes.ContentType')),
+                ('author', models.ForeignKey(blank=True, to=settings.AUTH_USER_MODEL, null=True, on_delete=django.db.models.deletion.CASCADE)),
+                ('content_type', models.ForeignKey(to='contenttypes.ContentType', on_delete=django.db.models.deletion.CASCADE)),
             ],
             options={
                 'verbose_name': 'Note',

diff --git a/notes/models.py b/notes/models.py
@@ -31,8 +31,8 @@ class Note(TimeStampedModel):
     """
     content = models.TextField(_('Content'))
     public = models.BooleanField(_('Public'), default=True)
-    author = models.ForeignKey(User, blank=True, null=True)
-    content_type = models.ForeignKey(ContentType)
+    author = models.ForeignKey(User, blank=True, null=True, on_delete=models.CASCADE)
+    content_type = models.ForeignKey(ContentType, on_delete=models.CASCADE)
     object_id = models.PositiveIntegerField()
     content_object = GenericForeignKey("content_type", "object_id")