Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

case-study: next-transpile / workspace / ts breakage #4

Merged
merged 19 commits into from
Aug 14, 2020

Conversation

belgattitude
Copy link
Owner

@belgattitude belgattitude commented Aug 14, 2020

Step by step attempt to make with-yarn-workspaces work with next-transpile / workspaces and typescript.

Related to this issue: martpie/next-transpile-modules#101

Started with an initial working situation (foo package is transpiled, but does not contains typings), then trying different version combinations.

Steps:

  • 1. Transpile foo package in ts (without typings) - NextJs 9.5.2/Transpile 4.1.0 - Works !
  • 2. Transpile foo package in ts (with typings) - NextJs 9.5.2/Transpile 4.1.0 - Does not works
  • 3. Transpile foo package in ts (with typings) - NextJs 9.4.4/Transpile 3.3.0 - Does not works
  • 4. Transpile foo package in ts (with typings) - NextJs 9.3.6/Transpile 3.1.0 - Does not works
  • 5. Fix missing 'foo' transpilation - I'm stupid. It works :)

@vercel
Copy link

vercel bot commented Aug 14, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/belgattitude/next-transpile-ts-workspace/96gqazxty
✅ Preview: https://next-transpile-ts-workspace-git-case-study-whenitbroke.belgattitude.vercel.app

@belgattitude belgattitude changed the title case-study: Bar (untranspiled) in typescript case-study: next-transpile / workspace / ts breakage Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant