Add support for PHP 8.4 and update code accordingly #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the GitHub workflow to include PHP 8.4 in the matrix and modifies constructor signatures in `CanonicalRange.php` and `Range.php` to handle nullability better, aligning with new PHP 8.4 standards. Additionally, minor corrections are made in `README.md` and `.gitignore` to improve clarity and ignore the new PHPUnit cache files.
|
Hello @belamov I found this issue updating my stack to PHP 8.4 today. I would like to contribute with this small fix. |
|
hello, thanks a lot for this pr! |
belamov
reviewed
Dec 6, 2024
|
@isalcedo can you please check the failed job? i dont understand whats the problem to be honest :) |
belamov
reviewed
Dec 6, 2024
Added tests for Laravel 8 with PHP versions 8.2, 8.3, and 8.4. Removed tests for Laravel 11 with PHP versions 8.2, 8.3, and 8.4 to streamline testing focus. This ensures compatibility checks with relevant Laravel versions for current PHP environments.
I made the changes, it needs your approval to run the actions. |
belamov
reviewed
Dec 7, 2024
This change eliminates unnecessary PHP 8.2, 8.3, and 8.4 configurations with Laravel 8.*, streamlining the CI workflow. By focusing on the essential version pairings, we maintain clarity and improve the maintainability of our build matrix.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #28 +/- ##
=========================================
Coverage 99.51% 99.51%
Complexity 81 81
=========================================
Files 21 21
Lines 208 208
=========================================
Hits 207 207
Misses 1 1 ☔ View full report in Codecov by Sentry. |
|
thanks a lot for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 😄
This commit updates the GitHub workflow to include PHP 8.4 in the matrix and modifies constructor signatures in
CanonicalRange.phpandRange.phpto handle nullability better, aligning with new PHP 8.4 standards. Additionally, minor corrections are made inREADME.mdand.gitignoreto improve clarity and ignore the new PHPUnit cache files.