Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ETHOS-39859): add support to update /etc/apt/sources.list #76

Merged
merged 3 commits into from
Feb 2, 2023
Merged

feat(ETHOS-39859): add support to update /etc/apt/sources.list #76

merged 3 commits into from
Feb 2, 2023

Conversation

adobejmong
Copy link
Collaborator

@adobejmong adobejmong commented Aug 28, 2022 •
edited
Loading

Added

  • New script update_apt_sources.sh which takes in optional env vars to update /etc/apt/sources.list
  • Documentation on how to use the script
  • Support for shunit2 unit tests
    • Dockerfile for building shunit2 tests
    • Makefile for building and running the tests
    • Script to run all the tests
    • Test for update_apt_sources.sh
    • Documentation on how to build / run the tests

Removed

  • Remove gpg s6-overlay validation since it keeps failing to validate. See troubleshooting. In the future, the validation method for newer s6-overlay packages (starting with 3.x, we're still on 2.x) will be much easier by simply using the sha256 checksum
  • Remove Ubuntu 18.04 from variant list. Will remove from builds in November 2022.

Updated

  • Updated table of variants and add removal date

@adobejmong adobejmong self-assigned this Aug 28, 2022
@adobejmong adobejmong added enhancement ubuntu ubuntu linux related updates labels Aug 28, 2022
Jan Michael Ong added 2 commits August 28, 2022 12:03
fix(ETHOS-38803): remove gpg validation. step fails with keyserver: EOF
e545023 
Notes:
* Need to switch to newer version of s6-overlay which uses SHA256
  checksum validation instead
docs: remove ubuntu 18.04, add removal date
d8840e6
@adobejmong adobejmong merged commit 8226e92 into behance:master Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@adobejmong adobejmong

Labels
enhancement ubuntu ubuntu linux related updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@adobejmong