Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPU Arch: added helper script for simple string replacements #66

Merged
merged 12 commits into from
Dec 6, 2021
Merged

CPU Arch: added helper script for simple string replacements #66

merged 12 commits into from
Dec 6, 2021

Conversation

bryanlatten
Copy link
Contributor

@bryanlatten bryanlatten commented Dec 5, 2021 •
edited
Loading

@bryanlatten
Copy link
Contributor Author

@tnaroska have a look in its pseudo final form now :)

adobejmong
adobejmong approved these changes Dec 6, 2021
View reviewed changes
Copy link
Collaborator

@adobejmong adobejmong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Noted a small change.

@adobejmong adobejmong self-assigned this Dec 6, 2021
@bryanlatten
Copy link
Contributor Author

thanks for all your comments! for the latest commit...Travis ARM version is simply failing to spin up or connect to git. I'll keep retrying the job until it works...https://app.travis-ci.com/github/behance/docker-base/jobs/551065422

@bryanlatten
Copy link
Contributor Author

finally, passing tests! merging.

@bryanlatten bryanlatten merged commit a00ed1a into behance:master Dec 6, 2021
@bryanlatten bryanlatten deleted the feature-archstring branch December 6, 2021 20:32
@tnaroska
Copy link

tnaroska commented Dec 6, 2021

Great! What do we need to do to get these as multiarch images deployed to dockerhub?
Still seems intel only:
https://hub.docker.com/r/behance/docker-base/tags

@bryanlatten
Copy link
Contributor Author

@tnaroska working on that separately. if you are interested in swapping travis for github actions to do a publish?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adobejmong adobejmong adobejmong approved these changes

@ko-be ko-be ko-be approved these changes

@tnaroska tnaroska tnaroska approved these changes

@bossjones bossjones bossjones approved these changes

Assignees

@adobejmong adobejmong

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bryanlatten @tnaroska @bossjones @ko-be @adobejmong