Skip to content

Commit

Permalink
Merge pull request #2637 from freakboy3742/ci-flaky
Browse files Browse the repository at this point in the history
Correct flakiness in macOS CI
  • Loading branch information
freakboy3742 authored Jun 11, 2024
2 parents 76efbba + 4d59019 commit 1ae8563
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,11 @@ jobs:
sudo udevadm control --reload-rules
sudo udevadm trigger --name-match=kvm
steps:
# Github runners seem to have intermittent connectivity issues.
# See https://github.com/beeware/toga/issues/2632
- name: Tune GitHub-hosted runner network
uses: smorimoto/tune-github-hosted-runner-network@v1.0.0

- name: Checkout
uses: actions/checkout@v4.1.6
with:
Expand Down
1 change: 1 addition & 0 deletions changes/2631.misc.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
An intermittent failure in macOS CI was corrected.
1 change: 1 addition & 0 deletions changes/2632.misc.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
An step has been added to the Github actions configuration to fix an issue with Github's network configuration.
3 changes: 3 additions & 0 deletions testbed/tests/test_window.py
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,9 @@ async def test_secondary_window_with_content(app):
assert window_with_content.content == content
finally:
window_with_content.close()
await window_with_content_probe.redraw("Secondary window has been closed")
del window_with_content
gc.collect()

async def test_secondary_window_cleanup(app_probe):
"""Memory for windows is cleaned up when windows are deleted."""
Expand Down

0 comments on commit 1ae8563

Please sign in to comment.