Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manually update pre-commit hooks to latest versions #63

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Manually update pre-commit hooks to latest versions #63

merged 1 commit into from
Nov 2, 2023

Conversation

rmartin16
Copy link
Member

@rmartin16 rmartin16 commented Nov 2, 2023 •
edited
Loading

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@rmartin16 rmartin16 force-pushed the update-pre-commit-hooks branch from e8dac4b to 8121a2c Compare November 2, 2023 21:34
freakboy3742
freakboy3742 approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this should automatically happen on Sunday with the overnights, but it can't hurt to get ahead of things.

@freakboy3742 freakboy3742 merged commit e44c162 into beeware:main Nov 2, 2023
8 checks passed
@rmartin16 rmartin16 deleted the update-pre-commit-hooks branch November 2, 2023 22:25
@rmartin16
Copy link
Member Author

I'm guessing this should automatically happen on Sunday with the overnights, but it can't hurt to get ahead of things.

Only if the reason the pre-commit-update workflow has been failing is resolved before then....I made an attempt in #57 but I honestly haven't looked closely enough at it to understand the immediate next steps.

@freakboy3742
Copy link
Member

Ah - well, hopefully that will be this Sunday, because a Toga release should be a couple of hours away, and the toga-chart update should be hot on the heels after that :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PRs fail flake8 in CI for already existing code.
2 participants
@rmartin16 @freakboy3742