Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in towncrier-check #18

Merged
merged 2 commits into from
Aug 16, 2022
Merged

Fix bug in towncrier-check #18

merged 2 commits into from
Aug 16, 2022

Conversation

saroad2
Copy link
Member

@saroad2 saroad2 commented Aug 16, 2022

The towncrier-check command is failing because it is trying to compare the PR branch with origin/master, which no longer exists.

This PR changes that so it compares the branch with origin/main.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

freakboy3742
freakboy3742 approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Still squishing these after the great rename 6 months ago...

@freakboy3742 freakboy3742 merged commit 5e7605e into beeware:main Aug 16, 2022
@saroad2 saroad2 deleted the fix_towncrier_check_bug branch August 17, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saroad2 @freakboy3742