Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove transitory obsolete cache directory check #1052

Merged
merged 1 commit into from
Jan 20, 2023
Merged

Remove transitory obsolete cache directory check #1052

merged 1 commit into from
Jan 20, 2023

Conversation

rmartin16
Copy link
Member

@rmartin16 rmartin16 commented Jan 19, 2023 •
edited
Loading

Removes the check for the old Briefcase cache directory at ~/.briefcase introduced in #777.

This also appears to have removed the last usage of briefcase.exceptions.InfoHelpText but I didn't remove the exception since it may be useful in the future as it has been in the past.

Well...we're failing coverage with InfoHelptText....so, I guess it'll have to be recreated if it's needed again.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@rmartin16 rmartin16 force-pushed the remove-cache-dir-check branch from 218795d to c28651e Compare January 19, 2023 23:45
@rmartin16 rmartin16 force-pushed the remove-cache-dir-check branch from c28651e to 1fbcde6 Compare January 20, 2023 00:01
@rmartin16 rmartin16 marked this pull request as ready for review January 20, 2023 00:32
freakboy3742
freakboy3742 approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't argue with the TODO comment :-)

@freakboy3742 freakboy3742 merged commit c9409bd into beeware:main Jan 20, 2023
@rmartin16 rmartin16 deleted the remove-cache-dir-check branch January 20, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmartin16 @freakboy3742