-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'Write' command to update tags hangs on NAS drive #1268
Comments
Thanks for getting in touch. Network filesystems can indeed be quite flakey, depending the driver and the NAS, so it's not too shocking that writes could hang occasionally. Perhaps you can try narrowing it down to specific files? And if it really is random, maybe you can reproduce it with a simple shell script that just tries writing files until it hangs, so you have something you can report to your NAS vendor (or OS maintainer)? |
Thanks for the quick feedback Adrian. I can give it a go. Was mostly On 24 January 2015 at 21:06, Adrian Sampson notifications@github.com
|
Yeah, I wish there were more detail to offer here—the verbose mode you've been using is as detailed as we get currently. If you can fight your way through some Python, I recommend trying to add some print-logging in the write command function in |
Ok . Will take a look. btw: Thanks for putting the whole beets thing together. No one else was... On 24 January 2015 at 21:24, Adrian Sampson notifications@github.com
|
Hiya Am still trying to work out the 'write' issue. I've not delved into python When carrying out a 'write' it acts oddly in two ways: Odd Behaviour #1 - Even though the metadata has already written out to the Odd Behaviour #2 - When the 'write' command hangs, it always seems to do so Have you had a situation before where only some of the metadata updates on Example hang: Thanks for all the advice! On 24 January 2015 at 23:51, Dosman admin@dosman.co.uk wrote:
|
The bitrate field cannot change: it is not a tag, but metadata about the audio file. Some formats don't even have bitrate metadata, so beets calculates it based on the file size. If we're showing a modification for fields like that, then that's a UI bug.
Can you supply samples so we can reproduce? |
Can do; however in the mean time I took some of the offending files off of It looks like it's still a NAS issue, so it may not help to provide you On 26 January 2015 at 22:25, Adrian Sampson notifications@github.com
|
OK, let's chalk this up to a network filesystem bug for now. Good luck! |
As a work around then; is it possible to form a beets query which will On 27 January 2015 at 09:30, Adrian Sampson notifications@github.com
|
Can you explain what you mean by this? I don't know how a query would "ignore the bitrate field". Are you saying that the |
Hi Adrian
Yep - when trying a global 'write' on the NAS beets tries to update the As mentioned previously the bitrate updating doesn't occur when the files
|
Thank you for clarifying! I just pushed a fix for |
Cool! Have updated beets to the nightly and have started a global write. Thanks Adrian! ~$ beet -v write On 27 January 2015 at 23:04, Adrian Sampson notifications@github.com
|
Ok - the new beets version has definitely fixed the problem where it Many thanks for your help. On 28 January 2015 at 07:45, Dosman admin@dosman.co.uk wrote:
|
With 1.3.10, I can't write MP3s on my NAS, but I can write FLAC.
(Hang, file untouched) |
Also on NAS files I've been getting a lot of original_day tag writes that Los Campesinos! - Romance Is Boring - I Warned You: Do Not Make an Enemy of On 4 February 2015 at 05:59, tlc notifications@github.com wrote:
|
They're chasing the original_day issue in #1303. Do you still have hangs? Did they correspond to MP3s, or all you all FLAC? |
Still getting hangs on particular files, but after a few attempts it will On 4 February 2015 at 12:55, tlc notifications@github.com wrote:
|
Yep it is hanging on flacs. Haven't tried mp3s, but will do so. On 4 February 2015 at 13:01, Dosman admin@dosman.co.uk wrote:
|
Hi
I have an beets database where I imported my music library (236 GB of flacs, 700 albums), which is contained externally on a NAS drive. When I now do a 'beet -v write' command to go in and fill in all the metadata the write command starts for a while but eventually hangs (have found it stops for up to 8 hours before I kill the process).
The verbose output shows the tag updates, then "Sending event: write Sending event: after_write Sending event: database_change". After a while of this though it gets to a "Sending event: write" and then stops.
I don't know how to work out whether this is an issue with beets or with the NAS drive. I've looked at the permissions of the files that worked and those that didn't, but don't see anything different and in this case the problem appears to occur half way through an album so it shouldn't be a permissions issue.
Do you have any advice for checks I can carry out, or other logfiles to check?
Thanks!
The text was updated successfully, but these errors were encountered: