Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #1961

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Update dependencies #1961

merged 1 commit into from
Jul 21, 2020

Conversation

bcoles
Copy link
Collaborator

@bcoles bcoles commented Jul 8, 2020

This updates the minimum required version of several dependencies to non-vulnerable versions.

BeEF probably is not vulnerable to the vulnerabilities in these libraries; however, it is reasonable to assume that BeEF will be running on systems with fairly up-to-date dependencies, thus it makes sense to ensure BeEF requires update-to-date dependencies and is tested with up-to-date dependencies.

I have no idea if this change breaks anything breaks anything.

@bcoles bcoles added the Install label Jul 8, 2020
@jcrew99
Copy link
Collaborator

jcrew99 commented Jul 8, 2020

I'll run it locally and go through manually to see if anything is affected plus if all the automated tests pass then that means the changes shouldn't have affected anything covered.

@bcoles
Copy link
Collaborator Author

bcoles commented Jul 8, 2020

I'll run it locally and go through manually to see if anything is affected plus if all the automated tests pass then that means the changes shouldn't have affected anything covered.

bundle exec rake --all tests pass locally for me. Ruby 2.7.1p83.

@jcrew99
Copy link
Collaborator

jcrew99 commented Jul 8, 2020

It works fine for me locally as well (2.7.0) as the local tests but i ran into a bug with the install script. It would make a sudo apt-get update before installing on the dependencies which is fine normally but set -euo pipefail is set(which is good practice) but will fail due to apt-get update throwing an error code as the rolling release isnt released yet. I can't get it to happen again but it may be an issue

@jackdwalker
Copy link
Contributor

jackdwalker commented Jul 9, 2020

I could not replicate your issue @jcrew99 :( Spun up a fresh Kali 2020x1 box, updated + installed BeEF and had no problems.

All works fine for me locally on my primary Kali VM and the fresh box.

@jackdwalker
Copy link
Contributor

Doesn't look like any further discussion will be occurring here. Merging.

@jackdwalker jackdwalker merged commit 967bcf4 into master Jul 21, 2020
@bcoles bcoles deleted the bcoles-patch-1 branch July 21, 2020 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants