Fixes for test cases

beckerzito · Jan 19, 2024 · 9e4a8f3 · 9e4a8f3
1 parent f31abc4
commit 9e4a8f3
Show file tree

Hide file tree

Showing 5 changed files with 41 additions and 22 deletions.
diff --git a/examples/all-clusters-app/all-clusters-common/all-clusters-app.matter b/examples/all-clusters-app/all-clusters-common/all-clusters-app.matter
@@ -7619,6 +7619,9 @@ endpoint 1 {
     callback attribute attributeList;
     ram      attribute featureMap default = 0;
     ram      attribute clusterRevision default = 1;
+
+    handle command ChangeToMode;
+    handle command ChangeToModeResponse;
   }
 
   server cluster LaundryDryerControls {

diff --git a/examples/all-clusters-app/all-clusters-common/all-clusters-app.zap b/examples/all-clusters-app/all-clusters-common/all-clusters-app.zap
@@ -8150,7 +8150,7 @@
               "storageOption": "External",
               "singleton": 0,
               "bounded": 0,
-              "defaultValue": "",
+              "defaultValue": null,
               "reportable": 1,
               "minInterval": 1,
               "maxInterval": 65534,
@@ -8166,7 +8166,7 @@
               "storageOption": "External",
               "singleton": 0,
               "bounded": 0,
-              "defaultValue": "",
+              "defaultValue": null,
               "reportable": 1,
               "minInterval": 1,
               "maxInterval": 65534,
@@ -8182,7 +8182,7 @@
               "storageOption": "External",
               "singleton": 0,
               "bounded": 0,
-              "defaultValue": "",
+              "defaultValue": null,
               "reportable": 1,
               "minInterval": 1,
               "maxInterval": 65534,
@@ -8198,7 +8198,7 @@
               "storageOption": "External",
               "singleton": 0,
               "bounded": 0,
-              "defaultValue": "",
+              "defaultValue": null,
               "reportable": 1,
               "minInterval": 1,
               "maxInterval": 65534,
@@ -8214,7 +8214,7 @@
               "storageOption": "External",
               "singleton": 0,
               "bounded": 0,
-              "defaultValue": "",
+              "defaultValue": null,
               "reportable": 1,
               "minInterval": 1,
               "maxInterval": 65534,
@@ -8230,7 +8230,7 @@
               "storageOption": "External",
               "singleton": 0,
               "bounded": 0,
-              "defaultValue": "",
+              "defaultValue": null,
               "reportable": 1,
               "minInterval": 1,
               "maxInterval": 65534,
@@ -8246,7 +8246,7 @@
               "storageOption": "External",
               "singleton": 0,
               "bounded": 0,
-              "defaultValue": "",
+              "defaultValue": null,
               "reportable": 1,
               "minInterval": 1,
               "maxInterval": 65534,
@@ -8262,7 +8262,7 @@
               "storageOption": "External",
               "singleton": 0,
               "bounded": 0,
-              "defaultValue": "",
+              "defaultValue": null,
               "reportable": 1,
               "minInterval": 1,
               "maxInterval": 65534,
@@ -8278,7 +8278,7 @@
               "storageOption": "External",
               "singleton": 0,
               "bounded": 0,
-              "defaultValue": "",
+              "defaultValue": null,
               "reportable": 1,
               "minInterval": 1,
               "maxInterval": 65534,
@@ -8326,6 +8326,24 @@
           "side": "server",
           "enabled": 1,
           "apiMaturity": "provisional",
+          "commands": [
+            {
+              "name": "ChangeToMode",
+              "code": 0,
+              "mfgCode": null,
+              "source": "client",
+              "isIncoming": 1,
+              "isEnabled": 1
+            },
+            {
+              "name": "ChangeToModeResponse",
+              "code": 1,
+              "mfgCode": null,
+              "source": "server",
+              "isIncoming": 0,
+              "isEnabled": 1
+            }
+          ],
           "attributes": [
             {
               "name": "SupportedModes",

diff --git a/src/app/tests/suites/certification/Test_TC_OTCCM_2_1.yaml b/src/app/tests/suites/certification/Test_TC_OTCCM_2_1.yaml
@@ -32,7 +32,7 @@ config:
         defaultValue: 10
     invalid_mode_th:
         type: int8u
-        defaultValue: 5
+        defaultValue: 15
 
 tests:
     - label:
@@ -54,7 +54,6 @@ tests:
           constraints:
               type: list
               minLength: 2
-              contains: NewMode_CHANGE_FAIL
 
     - label: "Step 3: TH reads from the DUT the CurrentMode attribute."
       PICS: OTCCM.S.A0001
@@ -112,8 +111,7 @@ tests:
           "Step 7: TH sends a ChangeToMode command to the DUT with NewMode set
           to PIXIT.OTCCM.MODE_CHANGE_FAIL"
       PICS:
-          OTCCM.S.M.CAN_TEST_MODE_FAILURE && LWM.S.C00.Rsp &&
-          PICS_SKIP_SAMPLE_APP
+          OTCCM.S.M.CAN_TEST_MODE_FAILURE && OTCCM.S.C00.Rsp && PICS_SKIP_SAMPLE_APP
       verification: |
           Note : Please skip this step as SDK is not enabled with this failure response
 

diff --git a/src/app/tests/suites/certification/Test_TC_OTCCM_3_1.yaml b/src/app/tests/suites/certification/Test_TC_OTCCM_3_1.yaml
@@ -60,7 +60,7 @@ tests:
       response:
           saveAs: on_mode_dut
           constraints:
-              type: int16u
+              type: int8u
 
     - label: "Step 3: TH reads from the DUT the CurrentMode attribute."
       PICS: OTCCM.S.A0001 && OTCCM.S.F00
@@ -69,7 +69,7 @@ tests:
       response:
           saveAs: old_current_mode_dut
           constraints:
-              type: int16u
+              type: int8u
 
     - label:
           "If on_mode_dut is equal to old_current_mode_dut proceed to step 4.
@@ -82,10 +82,10 @@ tests:
                 value: on_mode_dut
               - name: "Value2"
                 value: old_current_mode_dut
-          response:
-              - values:
-                    - name: "Equals"
-                      saveAs: IsExpectedValue
+      response:
+          - values:
+                - name: "Equals"
+                  saveAs: IsExpectedValue
 
     - label: "Step 4: TH reads from the DUT the SupportedModes attribute."
       runIf: IsExpectedValue
@@ -127,4 +127,4 @@ tests:
       command: "readAttribute"
       attribute: "CurrentMode"
       response:
-      value: on_mode_dut
+        value: on_mode_dut
diff --git a/src/app/tests/suites/certification/ci-pics-values b/src/app/tests/suites/certification/ci-pics-values
@@ -754,11 +754,11 @@ LWM.S.M.CAN_TEST_MODE_FAILURE=1
 OTCCM.S=1
 OTCCM.S.A0000=1
 OTCCM.S.A0001=1
-OTCCM.S.A0003=1
 OTCCM.S.A0002=0
+OTCCM.S.A0003=0
 
 #Feature
-OTCCM.S.F00=1
+OTCCM.S.F00=0
 
 #Command
 OTCCM.S.C00.Rsp=1