add decode option to redact line sequence data from CSV #123
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses
CSVs might contain sensitive data, so we could allow a decode option to not include that data as part of the exception messaging.
Open questions
It could be argued that this isn't needed at all and apps using this library could just not log this out when they get this exception. But for long standing apps, it might be easier for them to add this decode option in the few areas where they need to without changing any other telemetry or logging.
The naming from the option was inspired by the ecto field option
redact
. I thought this might be a similar situation.Lastly, I notice we are just adding another parameter to all the functions here. This is outside the scope of this PR, but would it possibly be better to pass around the options starting at
create_row_transform
, and then extract them when needed down the line?Checklist