-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate circleci configuration to 2.0 #411
Migrate circleci configuration to 2.0 #411
Conversation
Why was there a change made to mix.lock ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are two areas you could drop
.circleci/config.yml
Outdated
- run: mix test | ||
- run: MIX_ENV=prod mix compile | ||
|
||
- store_test_results: # upload test results for display in Test Summary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure storing test results is necessary, though I could be wrong.
.circleci/config.yml
Outdated
key: v1-build-cache | ||
paths: "_build" | ||
- run: mix test | ||
- run: MIX_ENV=prod mix compile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've found this is helpful to catch things that may only cause issues in prod.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this!
.circleci/config.yml
Outdated
paths: "deps" | ||
- save_cache: | ||
key: v1-mix-cache | ||
paths: "deps" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't used Circle 2.0 that much yet. Could you explain why multiple caches are needed here?
.circleci/config.yml
Outdated
key: v1-build-cache | ||
paths: "_build" | ||
- run: mix test | ||
- run: MIX_ENV=prod mix compile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've found this is helpful to catch things that may only cause issues in prod.
@joshchernoff
I have a newer version of elixir and mix. And mix made this changes. I'll revert them. |
@joshchernoff @paulcsmith Maybe cost of network traffic is higher than cost of storage and that's why they recommend to cache every version, branch and change of mix.lock. |
3b1e28f
to
d3c5cec
Compare
@joshchernoff @paulcsmith Ok. I removed all caches except one that depends on checksum of mix.lock. Also I removed |
d3c5cec
to
c9302c1
Compare
Thank you so much! |
No description provided.