Fixing compilation warnings #304
Conversation
| new_email() | ||
| # @user will be available in the template | ||
| |> render(:email_with_assigns, user: user) | ||
| if Code.ensure_loaded?(Phoenix) do |
There was a problem hiding this comment.
This is the only line added, the rest is only indentation.
There was a problem hiding this comment.
BTW, there is another way to do it, removing only: :test from phoenix dep declaration. But I found this one a little bit better since bamboo itself does not depend on phoenix.
Going far away in my imagination, I guess it would be a good idea to separate some of Phoenix and Plug code from here. This could be an umbrella project with three applications: bamboo with the basics, bamboo_phoenix to use some phoenix views to render and bambo_viewer for the email viewer.
Will be happy to open a PR to it if you liked the umbrella idea.
There was a problem hiding this comment.
Yes, I think at some point a bamboo_phoenix lib might be nice. For now this works great. Thank you so much!
|
Any chance this get merged? |
| new_email() | ||
| # @user will be available in the template | ||
| |> render(:email_with_assigns, user: user) | ||
| if Code.ensure_loaded?(Phoenix) do |
There was a problem hiding this comment.
Yes, I think at some point a bamboo_phoenix lib might be nice. For now this works great. Thank you so much!
62aa536 to
7e6052b
Compare
|
Thanks! Rebased! |
|
Thanks a ton! |
No description provided.