Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email preview collapsed html preview #350

Closed
RobinClowers opened this issue Feb 1, 2018 · 0 comments
Closed

Email preview collapsed html preview #350

RobinClowers opened this issue Feb 1, 2018 · 0 comments

Comments

@RobinClowers
Copy link
Contributor

When I use the email preview plug, the iframe that should show the html preview gets it's height set to 0, so I don't see the html version. If I change it in dev tools the email is there and rendering correctly.

germsvel pushed a commit that referenced this issue Feb 15, 2021
What changed?
----------------

This commit uses the `screen.availHeight` property as a fallback 
to how we currently set the iframe's height. See [screen docs]. 

[Screen docs]: https://developer.mozilla.org/en-US/docs/Web/API/Screen

Why?
-------

As part of the Wallaby feature test I've needed to read an email, 
but I could only get iframe element using 
`Wallaby.Query.css("iframe", visible: false)` because the height 
of the element is 0.

I've tried this in multiple versions of Chrome and chromedriver. 
Also, I've only been able to experience this in headless Chrome 
in macOS. I wasn't having this issue with Wallaby option 
headless: false nor on a CI instance running Ubuntu.

Related to #350 and 
#351
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant