Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests #15

Merged
merged 8 commits into from
Jul 2, 2021
Merged

Add more tests #15

merged 8 commits into from
Jul 2, 2021

Conversation

palday
Copy link
Member

@palday palday commented Jul 2, 2021

I also simplified the mime_string testing util and made the error catching for eltype conversions better.

@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #15 (2a0d9c3) into main (ff4425f) will increase coverage by 33.33%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             main       #15       +/-   ##
============================================
+ Coverage   66.66%   100.00%   +33.33%     
============================================
  Files           1         1               
  Lines          33        37        +4     
============================================
+ Hits           22        37       +15     
+ Misses         11         0       -11     
Impacted Files Coverage Δ
src/centering.jl 100.00% <100.00%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff4425f...2a0d9c3. Read the comment docs.

@palday palday requested a review from kleinschmidt July 2, 2021 15:57
@palday palday merged commit d4b4ef2 into main Jul 2, 2021
@palday palday deleted the pa/tests branch July 2, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants