Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send a message on the iopub channel when the client requests kernel info. #95

Merged
merged 2 commits into from
Feb 11, 2021
Merged

Send a message on the iopub channel when the client requests kernel info. #95

merged 2 commits into from
Feb 11, 2021

Conversation

bduggan
Copy link
Owner

@bduggan bduggan commented Feb 10, 2021 •
edited
Loading

Also handle comm_info_requests.

Updated the description of this PR. This will resolve #94

@bduggan bduggan force-pushed the implement_comm_info_request branch from 92af9ba to 894c34c Compare February 10, 2021 14:32
@bduggan
Copy link
Owner Author

bduggan commented Feb 10, 2021 •
edited
Loading

Possibly related to #94 -- but since the protocol version is 5.0.0, the client shouldn't be sending these requests

@bduggan
Emit status on iopub channel for nudge
6d61644 
Also Handle comm_info_request, add more kernel info
@bduggan bduggan force-pushed the implement_comm_info_request branch from b1baf18 to 6d61644 Compare February 11, 2021 14:22
@bduggan bduggan changed the title Handle comm_info_request Send a message on the iopub channel when the client requests kernel info. Feb 11, 2021
@bduggan
Copy link
Owner Author

bduggan commented Feb 11, 2021

url for testing: https://mybinder.org/v2/gh/bduggan/p6-jupyter-kernel/implement_comm_info_request

@bduggan
Copy link
Owner Author

bduggan commented Feb 11, 2021

This change seems to be necessary because of jupyter/notebook#5908

@bduggan bduggan merged commit 93d4d95 into master Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

perl6 on Binder unresponsive
1 participant
@bduggan