Use neostandard + add more static code analysis (#142)

* Use neostandard

* ci: add knip + rimraf + clean up with help of knip

* only run workflows on on `master` branch and PR:s

* tweak new npm scripts

* add installed-check

.github/workflows/test.yml

@@ -1,11 +1,30 @@
 name: tests
 
-on: [pull_request, push]
+on:
+  push:
+    branches:
+      - master
+    tags:
+      - '*'
+  pull_request:
+    branches:
+      - master
 
 env:
   FORCE_COLOR: 2
 
 jobs:
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Use Node.js lts/*
+        uses: actions/setup-node@v4
+        with:
+          node-version: lts/*
+      - run: npm i
+      - run: npm run check
+
   test:
     runs-on: ${{ matrix.os }}
 
@@ -22,14 +41,14 @@ jobs:
         with:
           node-version: ${{ matrix.node }}
       - run: npm i
-      - run: npm test
+      - run: npm run test-mocha
       - uses: codecov/codecov-action@v4
         if: ${{ github.event_name == 'pull_request' }}
         with:
           flags: ${{ matrix.os }}-${{ matrix.node }}
 
   automerge:
-    needs: test
+    needs: [lint, test]
     runs-on: ubuntu-latest
     permissions:
       pull-requests: write

.knip.jsonc

@@ -0,0 +1,5 @@
+{
+  "$schema": "https://unpkg.com/knip@5/schema.json",
+  "entry": ["lib/index.js", "bin/*/*.js", "test-workspace/tasks/*.js"],
+  "ignoreDependencies": ["rimraf", "yarn"]
+}

README.md

@@ -7,6 +7,7 @@
 [![Downloads/month](https://img.shields.io/npm/dm/npm-run-all2.svg)](http://www.npmtrends.com/npm-run-all2)
 [![tests](https://github.com/bcomnes/npm-run-all2/workflows/tests/badge.svg)](https://github.com/bcomnes/npm-run-all2/actions)
 [![Coverage Status](https://codecov.io/gh/bcomnes/npm-run-all2/branch/master/graph/badge.svg)](https://codecov.io/gh/bcomnes/npm-run-all2)
+[![neostandard javascript style](https://img.shields.io/badge/code_style-neostandard-brightgreen?style=flat)](https://github.com/neostandard/neostandard)
 
 A CLI tool to run multiple npm-scripts in parallel or sequential.
 

bin/common/bootstrap.js

@@ -8,7 +8,6 @@
 // ------------------------------------------------------------------------------
 // Public Interface
 // ------------------------------------------------------------------------------
-/* eslint-disable no-process-exit */
 
 module.exports = function bootstrap (name) {
   const argv = process.argv.slice(2)
@@ -47,5 +46,3 @@ module.exports = function bootstrap (name) {
       )
   }
 }
-
-/* eslint-enable */

bin/common/parse-cli-args.js

@@ -5,8 +5,6 @@
  */
 'use strict'
 
-/* eslint-disable no-process-env */
-
 // ------------------------------------------------------------------------------
 // Helpers
 // ------------------------------------------------------------------------------
@@ -243,5 +241,3 @@ function parseCLIArgsCore (set, args) {
 module.exports = function parseCLIArgs (args, initialValues, options) {
   return parseCLIArgsCore(new ArgumentSet(initialValues, options), args)
 }
-
-/* eslint-enable */

bin/npm-run-all/main.js

@@ -52,7 +52,7 @@ module.exports = function npmRunAll (args, stdout, stderr) {
             arguments: argv.rest,
             race: group.parallel && argv.race,
             npmPath: argv.npmPath,
-            aggregateOutput: group.parallel && argv.aggregateOutput
+            aggregateOutput: group.parallel && argv.aggregateOutput,
           }
         ))
       },
@@ -61,14 +61,12 @@ module.exports = function npmRunAll (args, stdout, stderr) {
 
     if (!argv.silent) {
       promise.catch(err => {
-        // eslint-disable-next-line no-console
         console.error('ERROR:', err.message)
       })
     }
 
     return promise
   } catch (err) {
-    // eslint-disable-next-line no-console
     console.error('ERROR:', err.message)
 
     return Promise.reject(err)

bin/run-p/main.js

@@ -52,20 +52,18 @@ module.exports = function npmRunAll (args, stdout, stderr) {
         arguments: argv.rest,
         race: argv.race,
         npmPath: argv.npmPath,
-        aggregateOutput: argv.aggregateOutput
+        aggregateOutput: argv.aggregateOutput,
       }
     )
 
     if (!argv.silent) {
       promise.catch(err => {
-        // eslint-disable-next-line no-console
         console.error('ERROR:', err.message)
       })
     }
 
     return promise
   } catch (err) {
-    // eslint-disable-next-line no-console
     console.error('ERROR:', err.message)
 
     return Promise.reject(err)

bin/run-s/main.js

@@ -49,20 +49,18 @@ module.exports = function npmRunAll (args, stdout, stderr) {
         packageConfig: argv.packageConfig,
         silent: argv.silent,
         arguments: argv.rest,
-        npmPath: argv.npmPath
+        npmPath: argv.npmPath,
       }
     )
 
     if (!argv.silent) {
       promise.catch(err => {
-        // eslint-disable-next-line no-console
         console.error('ERROR:', err.message)
       })
     }
 
     return promise
   } catch (err) {
-    // eslint-disable-next-line no-console
     console.error('ERROR:', err.message)
 
     return Promise.reject(err)

eslint.config.js

@@ -0,0 +1,9 @@
+'use strict'
+
+module.exports = [
+  ...require('neostandard')({
+    env: ['mocha'],
+    ignores: require('neostandard').resolveIgnoresFromGitignore(),
+    ts: true,
+  }),
+]

lib/index.js

@@ -228,7 +228,7 @@ function maxLength (length, name) {
  * @returns {Promise}
  *   A promise object which becomes fullfilled when all npm-scripts are completed.
  */
-module.exports = function npmRunAll (patternOrPatterns, options) { // eslint-disable-line complexity
+module.exports = function npmRunAll (patternOrPatterns, options) {
   const stdin = (options && options.stdin) || null
   const stdout = (options && options.stdout) || null
   const stderr = (options && options.stderr) || null
@@ -290,14 +290,14 @@ module.exports = function npmRunAll (patternOrPatterns, options) { // eslint-dis
             enabled: printLabel,
             width: labelWidth,
             lastPrefix: null,
-            lastIsLinebreak: true
+            lastIsLinebreak: true,
           },
           printName,
           packageInfo: x.packageInfo,
           race,
           maxParallel,
           npmPath,
-          aggregateOutput
+          aggregateOutput,
         })
       })
   } catch (err) {

lib/read-package-json.js

@@ -27,6 +27,6 @@ module.exports = function readPackageJson () {
   const path = joinPath(process.cwd(), 'package.json')
   return readPackage(path).then(body => ({
     taskList: Object.keys(body.scripts || {}),
-    packageInfo: { path, body }
+    packageInfo: { path, body },
   }))
 }

lib/run-task.js

@@ -167,14 +167,14 @@ module.exports = function runTask (task, options) {
       const basename = path.basename(process.env.npm_execpath)
       let newBasename = basename
       if (basename.startsWith('npx')) {
-        newBasename = basename.replace('npx', 'npm') // eslint-disable-line no-process-env
+        newBasename = basename.replace('npx', 'npm')
       } else if (basename.startsWith('pnpx')) {
-        newBasename = basename.replace('pnpx', 'pnpm') // eslint-disable-line no-process-env
+        newBasename = basename.replace('pnpx', 'pnpm')
       }
 
       npmPath = newBasename !== basename
         ? path.join(path.dirname(process.env.npm_execpath), newBasename)
-        : process.env.npm_execpath // eslint-disable-line no-process-env
+        : process.env.npm_execpath
     }
 
     const npmPathIsJs = typeof npmPath === 'string' && /\.(c|m)?js/.test(path.extname(npmPath))
@@ -191,7 +191,7 @@ module.exports = function runTask (task, options) {
       }
     }
 
-    const isYarn = process.env.npm_config_user_agent && process.env.npm_config_user_agent.startsWith('yarn') // eslint-disable-line no-process-env
+    const isYarn = process.env.npm_config_user_agent && process.env.npm_config_user_agent.startsWith('yarn')
 
     const spawnArgs = ['run']
 

lib/run-tasks.js

@@ -53,7 +53,7 @@ const signals = {
   SIGTTIN: 21,
   SIGTTOU: 22,
   SIGUSR1: 30,
-  SIGUSR2: 31
+  SIGUSR2: 31,
 }
 
 /**
@@ -142,7 +142,7 @@ module.exports = function runTasks (tasks, options) {
       const originalOutputStream = options.stdout
       const optionsClone = Object.assign({}, options)
       const writer = new MemoryStream(null, {
-        readable: false
+        readable: false,
       })
 
       if (options.aggregateOutput) {

lib/spawn.js

@@ -15,6 +15,4 @@
  * This is {@link ./spawn-posix.js:spawn} or {@link ./spawn-win32.js:spawn}
  * @private
  */
-module.exports = require(
-  process.platform === 'win32' ? './spawn-win32' : './spawn-posix'
-)
+module.exports = process.platform === 'win32' ? require('./spawn-win32') : require('./spawn-posix')

package.json

@@ -10,17 +10,21 @@
   },
   "main": "lib/index.js",
   "engines": {
-    "node": "^14.18.0 || >=16.0.0",
+    "node": "^14.18.0 || ^16.13.0 || >=18.0.0",
     "npm": ">= 8"
   },
   "scripts": {
-    "_mocha": "mocha --timeout 120000",
     "clean": "rm -rf coverage jsdoc \"test-workspace/{build,test.txt}\"",
     "docs": "jsdoc -c jsdoc.json",
-    "lint": "standard",
-    "pretest": "node scripts/make-slink.js && npm run lint",
-    "test": "c8 npm run _mocha",
-    "watch": "npm run _mocha -- --watch --growl",
+    "check:installed-check": "installed-check --ignore-dev",
+    "check:eslint": "eslint",
+    "check:knip": "knip",
+    "precheck": "node scripts/make-slink.js",
+    "check": "node ./bin/run-p/index.js check:*",
+    "pretest-mocha": "node scripts/make-slink.js",
+    "test-mocha": "c8 mocha --timeout 120000",
+    "test": "node ./bin/run-s/index.js check test-mocha",
+    "watch": "mocha --timeout 120000 --watch --growl",
     "version": "auto-changelog -p --template keepachangelog auto-changelog --breaking-pattern 'BREAKING CHANGE:' && git add CHANGELOG.md",
     "preversion": "npm test",
     "postversion": "git push --follow-tags && gh-release -y"
@@ -37,12 +41,14 @@
   "devDependencies": {
     "auto-changelog": "^2.2.0",
     "c8": "^10.0.0",
-    "fs-extra": "^11.1.0",
+    "eslint": "^9.6.0",
     "gh-release": "^7.0.0",
+    "installed-check": "^9.3.0",
     "jsdoc": "^4.0.0",
+    "knip": "^5.23.3",
     "mocha": "^10.0.0",
-    "p-queue": "^8.0.1",
-    "standard": "^17.1.0",
+    "neostandard": "^0.11.0",
+    "rimraf": "^5.0.7",
     "yarn": "^1.12.3"
   },
   "repository": {

test/aggregate-output.js

@@ -1,4 +1,3 @@
-/* eslint-env mocha */
 /**
  * @author Toru Nagashima
  * @copyright 2016 Toru Nagashima. All rights reserved.
@@ -40,7 +39,7 @@ describe('[aggregated-output] npm-run-all', () => {
       createExpectedOutput('second'),
       createExpectedOutput('third'),
       createExpectedOutput('first'),
-      ''
+      '',
     ].join('\n')
 
     let stdout = null
@@ -107,7 +106,7 @@ describe('[aggregated-output] npm-run-all', () => {
           'test-task:delayed first 5000',
           'test-task:delayed second 1000',
           'test-task:delayed third 3000',
-          '--silent', '--aggregate-output'
+          '--silent', '--aggregate-output',
         ],
         stdout
       )

test/argument-placeholders.js

@@ -1,4 +1,3 @@
-/* eslint-env mocha */
 /**
  * @author Toru Nagashima
  * @copyright 2016 Toru Nagashima. All rights reserved.
@@ -14,12 +13,7 @@ const assert = require('assert').strict
 const { strictEqual } = assert
 
 const nodeApi = require('../lib')
-const util = require('./lib/util')
-const result = util.result
-const removeResult = util.removeResult
-const runAll = util.runAll
-const runPar = util.runPar
-const runSeq = util.runSeq
+const { result, removeResult, runAll, runPar, runSeq } = require('./lib/util')
 
 // ------------------------------------------------------------------------------
 // Test