Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16627 - fix check for team membership deactivation #2652

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

ochiu
Copy link
Collaborator

@ochiu ochiu commented Nov 28, 2023

Issue #:
bcgov/entity#16627

Description of changes:

  • fix ADMIN check for membership deactivation

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.5% 0.5% Duplication

@ochiu ochiu marked this pull request as ready for review November 28, 2023 17:03
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #2652 (9406239) into main (261dc17) will increase coverage by 9.22%.
Report is 170 commits behind head on main.
The diff coverage is 89.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2652      +/-   ##
==========================================
+ Coverage   80.71%   89.93%   +9.22%     
==========================================
  Files         322      162     -160     
  Lines       11915     8726    -3189     
  Branches      618        0     -618     
==========================================
- Hits         9617     7848    -1769     
+ Misses       2289      878    -1411     
+ Partials        9        0       -9     
Flag Coverage Δ
accountmailerqueue ?
activityloglistenerqueue ?
authapi 89.93% <89.42%> (-0.03%) ⬇️
authweb ?
eventlistenerqueue ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
auth-api/src/auth_api/__init__.py 85.33% <100.00%> (ø)
auth-api/src/auth_api/config.py 99.39% <100.00%> (+<0.01%) ⬆️
auth-api/src/auth_api/exceptions/errors.py 100.00% <100.00%> (ø)
auth-api/src/auth_api/models/affiliation.py 94.82% <100.00%> (+2.14%) ⬆️
auth-api/src/auth_api/models/dataclass.py 100.00% <100.00%> (ø)
auth-api/src/auth_api/models/membership.py 72.41% <100.00%> (ø)
auth-api/src/auth_api/models/org.py 93.56% <100.00%> (+0.15%) ⬆️
auth-api/src/auth_api/models/product_code.py 96.66% <100.00%> (+0.11%) ⬆️
...th-api/src/auth_api/models/product_subscription.py 100.00% <ø> (ø)
auth-api/src/auth_api/resources/__init__.py 100.00% <100.00%> (ø)
... and 49 more

... and 160 files with indirect coverage changes

@seeker25 seeker25 merged commit ab5a10d into bcgov:main Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants