Make General Collateral required for Income Tax Act registration

[dimak1]

Issue #:

• Crown Charge Income Tax Act registration - General Collateral is required but entering Vehicle Collateral satisfies the edit in UI entity#18303
• PPR - Default General Collateral description is not displayed for Crown Charge Registrations entity#17491

Description of changes:

• Make General Collateral required for Income Tax Act registration
• Add unit test
• Update default text for General Collateral for certain Reg Types

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

[codecov]

Codecov Report

Merging #1619 (f24fb68) into main (9255e77) will increase coverage by 4.89%.
Report is 322 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1619      +/-   ##
==========================================
+ Coverage   72.35%   77.24%   +4.89%     
==========================================
  Files         307      379      +72     
  Lines       12767     7017    -5750     
  Branches     2630     1122    -1508     
==========================================
- Hits         9237     5420    -3817     
+ Misses       3518     1565    -1953     
- Partials       12       32      +20     

Flag	Coverage Δ
pprui	77.24% <ø> (+4.89%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
ppr-ui/src/App.vue	100.00% <ø> (+56.78%)	⬆️
ppr-ui/src/components/collateral/Collateral.vue	100.00% <ø> (+10.97%)	⬆️
...nents/collateral/generalCollateral/GenColAmend.vue	100.00% <ø> (+18.00%)	⬆️
...onents/collateral/generalCollateral/GenColEdit.vue	100.00% <ø> (+15.15%)	⬆️
...nts/collateral/generalCollateral/GenColSummary.vue	100.00% <ø> (+8.00%)	⬆️
...collateral/generalCollateral/GeneralCollateral.vue	100.00% <ø> (+6.66%)	⬆️
...ts/collateral/vehicleCollateral/EditCollateral.vue	100.00% <ø> (+22.58%)	⬆️
...collateral/vehicleCollateral/VehicleCollateral.vue	100.00% <ø> (+19.41%)	⬆️
...cleCollateral/factories/useCollateralValidation.ts	71.42% <ø> (ø)
...llateral/vehicleCollateral/factories/useVehicle.ts	70.14% <ø> (-0.91%)	⬇️
... and 34 more

... and 281 files with indirect coverage changes

[cameron-eyds]

Looks good!
Does this include the default value, as there was previous talk that was a similar issue or the root cause of this one?

[RuoxuanPengBC]

Looks great!

[dimak1]

Looks good! Does this include the default value, as there was previous talk that was a similar issue or the root cause of this one?

@cameron-eyds thanks for checking, there is a dependency ticket that I picked up, so I will add a fix in this PR as well.

[dimak1]

@cameron-eyds I added a default value for Gen Collateral, if you want to take a quick look. Now, once the user lands on that step, it would be immediately valid, because Gen Col is pre-filled (for certain reg types).

[dimak1]

/gcbrun

[bcregistry-sre]

Temporary Url for review: https://bcregistry-assets-dev--pr-1619-fqnow6wo.web.app