Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Payment Society to match the requirements from home team#24493 #1614

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

stevenc987
Copy link
Collaborator

Issue #, if available: 24493

Description of changes:

  1. Updated the fields needed from home team
  2. Changed the field in the table
  3. Converted the temp NR to a formal NR

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

Signed-off-by: Steven Chen <steven.chen@gov.bc.ca>
Signed-off-by: Steven Chen <steven.chen@gov.bc.ca>
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

try:
json_input = request.get_json()
if not json_input:
return make_response(jsonify({'message': 'No input data provided'}), 400)
current_app.logger.debug(json_input)
current_app.logger.debug(f'Request Json: {json_input}')

Check notice

Code scanning / SonarCloud

Logging should not be vulnerable to injection attacks Low

Change this code to not log user-controlled data. See more on SonarQube Cloud
@stevenc987 stevenc987 merged commit 44c360c into bcgov:main Nov 22, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants