Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add condition to avoid duplicate expiration calculations #1519

Merged
merged 4 commits into from
Apr 11, 2024
Merged

add condition to avoid duplicate expiration calculations #1519

merged 4 commits into from
Apr 11, 2024

Conversation

eve-git
Copy link
Collaborator

@eve-git eve-git commented Apr 10, 2024

Issue #, if available:
bcgov/entity#19788

Description of changes:
add condition to avoid duplicate expiration calculations in payment processes for NR reapply

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

@seeker25
Copy link
Collaborator

Not a namex pro, but thanks for fixing this!

@rarmitag
Copy link
Collaborator

@eve-git - Find out why the tests are failing before merging

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@eve-git eve-git merged commit b9a437b into bcgov:main Apr 11, 2024
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants