18226 update the condtions of showing reapply button #1498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
bcgov/entity#18226
Description of changes:
The current conditions for displaying the reapply button are as follows:
The NR state is in ('CONDITIONAL', 'APPROVED').
The expiry date is equal or less than 14 days from now.
The expiry date is after the current date.
Typically, when the expiry date is reached (condition #3 not satisfy), a batch job updates the NR state to 'Expired,' making condition #1 unsatisfied and preventing the reapply button from showing up.
The expiration process involves setting the NR state to 'Expired' and removing the name from Solr conflict names. However, if the state hasn't been updated to 'Expired' by the batch job upon reaching the expiry date, the names remain in the conflict name list, affecting names cannot be used in other requests. In this case, I believe it is acceptable to allow users to reapply. Therefore, it may be unnecessary to include condition #3 above.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).