Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

17144 - updated changes for query, and json read #1448

Merged
merged 7 commits into from
Oct 20, 2023
Merged

17144 - updated changes for query, and json read #1448

merged 7 commits into from
Oct 20, 2023

Conversation

Rajandeep98
Copy link
Contributor

*Issue #17144
Description of changes:
Duplicate Name Requests

stevenc987
stevenc987 reviewed Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@stevenc987 stevenc987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Have you tested if it still works well when the user_email is null?

eve-git
eve-git reviewed Oct 4, 2023
View reviewed changes
api/namex/models/request.py Outdated Show resolved Hide resolved
eve-git
eve-git reviewed Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@eve-git eve-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. Just some minor coding format need to pay attention. Such as line 153 and 162 @name_requests.py

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

ozamani9gh
ozamani9gh approved these changes Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@ozamani9gh ozamani9gh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@ozamani9gh ozamani9gh merged commit c28630c into bcgov:main Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenc987 stevenc987 stevenc987 approved these changes

@eve-git eve-git eve-git approved these changes

@ozamani9gh ozamani9gh ozamani9gh approved these changes

@pwei1018 pwei1018 Awaiting requested review from pwei1018

@thorwolpert thorwolpert Awaiting requested review from thorwolpert

@mengdong19 mengdong19 Awaiting requested review from mengdong19 mengdong19 is a code owner

@rarmitag rarmitag Awaiting requested review from rarmitag rarmitag is a code owner

Assignees

@Rajandeep98 Rajandeep98

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rajandeep98 @stevenc987 @eve-git @ozamani9gh