21033 Use different entity types for continuation in NRs #763

severinbeauvais · 2024-04-30T19:40:39Z

Description of changes:

app version = 5.4.9
added missing entity type (CS) to enum
added cont in entity type data
added cont in types to list of BC types
updated MVE request action mapping for cont in
updated getters to return alternate entity type data for cont in vs BC
added CS to society code checks
added cont in codes to numbered entity types list

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

- added missing entity type (CS) to enum - added cont in entity type data - added cont in types to list of BC types - updated MVE request action mapping for cont in - updated getters to return alternate entity type data for cont in vs BC

severinbeauvais · 2024-04-30T19:41:36Z

pnpm-lock.yaml

Note that this repo now uses pnpm (instead of npm) so you get a different lock file. Most of the shell commands are the same.

This is good to know. Thanks.

severinbeauvais · 2024-04-30T19:42:14Z

src/enums/entity-types.ts

@@ -11,6 +11,7 @@ export enum EntityTypes {
  CCC = CorpTypeCd.CCC_CONTINUE_IN,
  CP = CorpTypeCd.COOP,
  CR = CorpTypeCd.CORPORATION,
+  CS = CorpTypeCd.CONT_IN_SOCIETY,


... Even though we have that other feature flag to redirect users straight to Society Online if they choose a society-anything NR.

severinbeauvais · 2024-04-30T19:44:14Z

src/list-data/entity-type-data.ts

@@ -281,6 +281,177 @@ export const EntityTypesBcData: EntityI[] = [
  }
 ]

+/** List of entity types for Continuation In NRs. */


This is almost the same as the EntityTypesBcData, above, except with only the 6 cont in entity types. The category and blurbs are the same.

(Yes, cont in coop is still CP. This is an ongoing discussion and may be fixed in a separate ticket.)

severinbeauvais · 2024-04-30T19:45:06Z

src/list-data/request-action-mapping.ts

-  EntityTypes.PAR
+  EntityTypes.PAR,
+  EntityTypes.SO,
+  EntityTypes.UL
 ]


I added 5 cont in types (since there is no new cont in type for CP), and sorted this list.

-> C, CBEN, CCC, CS and CUL

severinbeauvais · 2024-04-30T19:49:00Z

src/store/getters.ts

+          obj = EntityTypesContInData.find(ent => ent.value === entity)
+        } else {
+          obj = EntityTypesBcData.find(ent => ent.value === entity)
+        }


@JazzarKarim , @jamespaologarcia :

I don't love this implementation. An alternative is to keep using the EntityTypesBcData list and the "non-cont in" entity types (eg, ULC instead of CUL), but then swap the entity types later in the processing. What do you think? Which makes the most sense to you?

Without seriously refactoring a lot of stuff, we're kind of stuck with needing to toggle between "BC" and "cont in" types somewhere.

I'm OK with this as is. I'm thinking that since this is a very special case which I don't think will re-occur, we can keep as is here.

Now, if we stumble upon something like this in the future, we might want to reconsider but we don't want to have lots of conditions here. Thoughts? I'm OK with the alternative as well.

I think the readability makes up for the potential code duplication because it makes it clear right away why you're changing entity types.

Great point, James. Thanks.

Remember this when you following this architecture for your next project 😉

severinbeauvais · 2024-04-30T19:49:30Z

src/store/getters.ts

  } catch (err) {
    console.error('entityTypesBC() =', err) // eslint-disable-line no-console
-    return EntityTypesBcData
+    return []


The old code masked any errors here. The new code should be safe and make any errors obvious.

Note that any error here should be a code error that we should catch during testing, so displaying "nothing" is a good option.

If this was a runtime error (eg, not static data) then it should be handled differently as a regular user might see it.

👍👍 👍 👍

severinbeauvais · 2024-04-30T19:50:23Z

src/store/getters.ts

+      if (x.value === EntityTypes.CUL) {
+        x.shortlist = true
+        x.rank = 2
+      }


Limited Company (CR or C) is automatically added as the first element in the short list.

severinbeauvais · 2024-04-30T19:51:46Z

src/store/getters.ts

      // Shortlist order: Limited Company, Cooperative Association
      if (x.value === EntityTypes.CP) {
        x.shortlist = true
        x.rank = 2
-      } else if ([EntityTypes.FR, EntityTypes.GP, EntityTypes.UL].includes(x.value)) {
-        x.shortlist = null
-        x.rank = null


This else-if was not needed.

JazzarKarim

LGTM!

severinbeauvais · 2024-04-30T21:01:03Z

@eve-git , is that code-coverage error a remnant of the pnpm change you recently did?

- added cont in codes to numbered entity types list

severinbeauvais · 2024-04-30T23:04:20Z

/gcbrun

JazzarKarim · 2024-04-30T23:08:31Z

Last commit LGTM Sev 👍

bcregistry-sre · 2024-04-30T23:08:39Z

Temporary Url for review: https://namerequest-dev--pr-763-m2wjrmib.web.app

jamespaologarcia

LGTM

ketaki-deodhar

Looks good Sev!

severinbeauvais · 2024-05-01T23:09:38Z

Folks, sorry, but this solution got messy -- it was sending the continuation in codes (eg, "C") instead of the regular codes (eg, "CR") to NameX API, which was crashing (HTTP 500).

So I went with the alternate solution, which turns out to be much simpler. It will be in another PR.

Update: The new PR is #764.

- app version = 5.4.9

727e8c1

- added missing entity type (CS) to enum - added cont in entity type data - added cont in types to list of BC types - updated MVE request action mapping for cont in - updated getters to return alternate entity type data for cont in vs BC

severinbeauvais self-assigned this Apr 30, 2024

severinbeauvais requested review from jamespaologarcia and JazzarKarim April 30, 2024 19:40

severinbeauvais commented Apr 30, 2024

View reviewed changes

wip

947b614

JazzarKarim approved these changes Apr 30, 2024

View reviewed changes

severinbeauvais requested a review from eve-git April 30, 2024 21:00

- added CS to society code checks

727d07d

- added cont in codes to numbered entity types list

bcgov deleted a comment from bcregistry-sre Apr 30, 2024

severinbeauvais requested a review from ketaki-deodhar April 30, 2024 23:06

jamespaologarcia approved these changes May 1, 2024

View reviewed changes

ketaki-deodhar approved these changes May 1, 2024

View reviewed changes

severinbeauvais marked this pull request as draft May 1, 2024 22:28

severinbeauvais closed this May 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

21033 Use different entity types for continuation in NRs #763

21033 Use different entity types for continuation in NRs #763

severinbeauvais commented Apr 30, 2024 •

edited

Loading

severinbeauvais Apr 30, 2024

JazzarKarim Apr 30, 2024

severinbeauvais Apr 30, 2024

severinbeauvais Apr 30, 2024

severinbeauvais Apr 30, 2024 •

edited

Loading

severinbeauvais Apr 30, 2024 •

edited

Loading

JazzarKarim Apr 30, 2024

jamespaologarcia Apr 30, 2024

severinbeauvais Apr 30, 2024

severinbeauvais Apr 30, 2024

severinbeauvais Apr 30, 2024 •

edited

Loading

JazzarKarim Apr 30, 2024

severinbeauvais Apr 30, 2024 •

edited

Loading

severinbeauvais Apr 30, 2024

JazzarKarim left a comment

severinbeauvais commented Apr 30, 2024

severinbeauvais commented Apr 30, 2024

JazzarKarim commented Apr 30, 2024

bcregistry-sre commented Apr 30, 2024

jamespaologarcia left a comment

ketaki-deodhar left a comment

severinbeauvais commented May 1, 2024 •

edited

Loading

21033 Use different entity types for continuation in NRs #763

21033 Use different entity types for continuation in NRs #763

Conversation

severinbeauvais commented Apr 30, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

severinbeauvais Apr 30, 2024 • edited Loading

Choose a reason for hiding this comment

severinbeauvais Apr 30, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

severinbeauvais Apr 30, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

severinbeauvais Apr 30, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JazzarKarim left a comment

Choose a reason for hiding this comment

severinbeauvais commented Apr 30, 2024

severinbeauvais commented Apr 30, 2024

JazzarKarim commented Apr 30, 2024

bcregistry-sre commented Apr 30, 2024

jamespaologarcia left a comment

Choose a reason for hiding this comment

ketaki-deodhar left a comment

Choose a reason for hiding this comment

severinbeauvais commented May 1, 2024 • edited Loading

severinbeauvais commented Apr 30, 2024 •

edited

Loading

severinbeauvais Apr 30, 2024 •

edited

Loading

severinbeauvais Apr 30, 2024 •

edited

Loading

severinbeauvais Apr 30, 2024 •

edited

Loading

severinbeauvais Apr 30, 2024 •

edited

Loading

severinbeauvais commented May 1, 2024 •

edited

Loading