Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7653 Send staff payment data #389

Merged
merged 2 commits into from
May 28, 2021

Conversation

vysakh-menon-aot
Copy link
Collaborator

Issue #: /bcgov/entity#7653

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

Copy link
Collaborator

@cameron-eyds cameron-eyds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

I recommend that you bump up the app version number (in package.json and package-lock.json) so that we can verify the deployed app versions.

@severinbeauvais severinbeauvais merged commit f07141c into bcgov:main May 28, 2021
@vysakh-menon-aot vysakh-menon-aot deleted the feature/7653 branch May 28, 2021 16:53
@severinbeauvais
Copy link
Collaborator

I force-merged this even though there was probably a merge conflict due to app version, but I think that's OK in this case since 2 PRs are going in at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants