Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Staff Payment validation and UX fixes #388

Merged
merged 1 commit into from
May 28, 2021
Merged

Staff Payment validation and UX fixes #388

merged 1 commit into from
May 28, 2021

Conversation

severinbeauvais
Copy link
Collaborator

@severinbeauvais severinbeauvais commented May 27, 2021 •
edited
Loading

Issue #: /bcgov/entity#6554

Description of changes:

  • set Payment modal min width for better UX
  • adjusted Payment modal whitespace
  • updated Payment modal button order
  • updated Staff Payment validation (state instead of prop)
  • added Staff Payment error border
  • removed Staff Payment extra whitespace
  • moved specific base class to specific component
  • changed button ids to classnames (due to multiple instances)
  • moved Request Details class to parents
  • removed unused component from Payment Complete
  • updated unit tests
  • updated app version
  • updated shared dependencies
  • updated browsers list

See the list of validation tests in ticket, if you're curious.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

@severinbeauvais
- set Payment modal min width for better UX
7e8f660 
- adjusted Payment modal whitespace
- updated Payment modal button order
- updated Staff Payment validation (state instead of prop)
- added Staff Payment error border
- removed Staff Payment extra whitespace
- moved specific base class to specific component
- changed button ids to classnames (due to multiple instances)
- moved Request Details class to parents
- removed unused component from Payment Complete
- updated unit tests
- updated app version
- updated shared dependencies
- updated browsers list
@severinbeauvais severinbeauvais self-assigned this May 27, 2021
cameron-eyds
cameron-eyds approved these changes May 28, 2021
View reviewed changes
Copy link
Collaborator

@cameron-eyds cameron-eyds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@severinbeauvais severinbeauvais merged commit 0af4e1a into bcgov:main May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameron-eyds cameron-eyds cameron-eyds approved these changes

@vysakh-menon-aot vysakh-menon-aot vysakh-menon-aot approved these changes

@eve-git eve-git Awaiting requested review from eve-git eve-git is a code owner

Assignees

@severinbeauvais severinbeauvais

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@severinbeauvais @cameron-eyds @vysakh-menon-aot