Implemented staff payment #386
Conversation
af537f5 to
0a3af44
Compare
- implemented tabs in Payment modal - implemented Staff Payment "interface component" (between tab and shared component) - added auth-getter plugin - fetched keycloak roles - added state/setter/getter for keycloak roles - added state/setter/getter for staff payment data - added staff-payment feature flag - updated app version - NB: needs completion when Namex API can handle staff payment data - NB: this feature is guarded by a new feature flag (staff-payment-enabled) so that it can be tested in Dev before being completed and released in Test/Prod
| console.info('Got roles!') // eslint-disable-line no-console | ||
| } catch (error) { | ||
| // just log the error message | ||
| console.log(`Did not get roles (${error.message})`) // eslint-disable-line no-console |
There was a problem hiding this comment.
I decided to just log a friendly-looking message here (ie, not the stack trace) since this will happen every time a non-logged-in user loads this app.
| onCancel: { | ||
| type: Function, | ||
| default: async () => {} | ||
| } |
There was a problem hiding this comment.
I replaced onCancel with a prop decorator/declaration below, and deleted onActivate which is no longer used.
| @@ -0,0 +1,103 @@ | |||
| <template> | |||
There was a problem hiding this comment.
This is what I call an "interface component" that sits between the tab item and the shared component. It exists so that the tab item doesn't need to know about the low level details, and the shared component doesn't need to know about the high level getters/setters/etc. This interface component will be different in different apps.
| newRequestModel: NewRequestIF | ||
| errorModel?: {}, | ||
| staffPayment: StaffPaymentIF |
There was a problem hiding this comment.
This is where staff payment data is stored. It is not saved in the NR or payment yet -- this is future work that will be dictated by the spike ticket and API ticket in this story (6288).
| @@ -0,0 +1,33 @@ | |||
| import { SessionStorageKeys } from 'sbc-common-components/src/util/constants' | |||
There was a problem hiding this comment.
This is just a copy of this helper/util file from our other apps.
Issue #: /bcgov/entity#6554
This is the first part of the UI implementation, so that it can be reviewed by the UX team. Although this is exactly according to the design comps, I expect some changes will be requested. Also, the implementation needs to be completed in a future PR when the namex API is updated to support staff payment data.
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).