Skip to content

Commit

Permalink
19384 PNPM replacement (#758)
Browse files Browse the repository at this point in the history
* disable Action button when change name to a numbered company and is not in supported change name FF

* pnpm replacement

* remove Dockerfile and Makefile

* update ci

* add build check
  • Loading branch information
eve-git authored Apr 24, 2024
1 parent 09397f1 commit 1872c7a
Show file tree
Hide file tree
Showing 8 changed files with 14,271 additions and 22,303 deletions.
74 changes: 7 additions & 67 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,77 +3,17 @@ name: NAMEREQUEST UI CI
on:
pull_request:
types: [assigned, synchronize]
workflow_dispatch:

defaults:
run:
shell: bash
working-directory: ./

jobs:
setup-job:
runs-on: ubuntu-20.04

if: github.repository == 'bcgov/namerequest'

steps:
- uses: actions/checkout@v3
- run: "true"

linting:
needs: setup-job
runs-on: ubuntu-20.04

strategy:
matrix:
node-version: [20.5.1]

steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- name: Install dependencies
run: |
make setup
- name: Linting
run: |
make lint
testing-coverage:
needs: setup-job
runs-on: ubuntu-20.04

strategy:
matrix:
node-version: [20.5.1]

steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- name: Install dependencies
run: |
make setup
- name: Test with Jest
id: test
run: |
make test
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v3
with:
name: codecov-name-request
fail_ci_if_error: true

build-check:
needs: setup-job
runs-on: ubuntu-20.04

steps:
- uses: actions/checkout@v3
- name: build to check strictness
id: build
run: |
make build-nc
namerequest-ci:
uses: bcgov/bcregistry-sre/.github/workflows/frontend-ci.yaml@main
with:
app_name: "namerequest"
working_directory: "./"
codecov_flag: ""
23 changes: 0 additions & 23 deletions Dockerfile

This file was deleted.

81 changes: 0 additions & 81 deletions Makefile

This file was deleted.

12 changes: 6 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,32 +6,32 @@

## Project setup
```
npm install
pnpm install
```

### Compiles and hot-reloads for development
```
npm run serve
pnpm run serve
```

### Compiles and minifies for production
```
npm run build
pnpm run build
```

### Run your tests
```
npm run test
pnpm run test
```

### Lints and fixes files
```
npm run lint
pnpm run lint
```

### Run your unit tests
```
npm run test:unit
pnpm run test:unit
```

### Customize configuration
Expand Down
Loading

0 comments on commit 1872c7a

Please sign in to comment.