Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24988 now documents temp business #3182

Merged
merged 10 commits into from
Jan 29, 2025

Conversation

kzdev420
Copy link
Collaborator

@kzdev420 kzdev420 commented Jan 24, 2025

Issue #: /bcgov/entity#24988 /bcgov/entity#25418

Description of changes:

24988 - Update code for getting NoW documents and comments for Temporary Businesses

Temp_identifier: Ts49zoGeVe

Filing_id: 161950

Screenshot 2025-01-23 at 4 02 20 PM

Receipt

Receipt.pdf

noticeOfWithdrawal

Notice_of_Withdrawal.pdf

25418 - Documents missed for WITHDRAWN status

Temp_identifier: Ts49zoGeVe

IA Filing_id: 161949

Screenshot 2025-01-28 at 1 14 21 PM

Outputs
IA outputs.pdf
Receipt-161949.pdf

Temp_identifier: BC0883809

IA Filing_id: 155476

Screenshot 2025-01-28 at 1 44 46 PM

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@kzdev420 kzdev420 self-assigned this Jan 24, 2025
@ArwenQin
Copy link
Collaborator

May I know whether it works for the embedded in NoW filing of a temp business? Can it get documents?

@kzdev420
Copy link
Collaborator Author

May I know whether it works for the embedded in NoW filing of a temp business? Can it get documents?

It can get the documents

eason-pan-bc

This comment was marked as resolved.

@kzdev420
Copy link
Collaborator Author

Invoice for T business output missed the business name part. pr-review-1

Please make sure all outputs follow the design: https://www.figma.com/design/CLqwqGQYARaSrnzLwh6w8Q/Notice-of-Withdrawal?node-id=883-69288&p=f&t=W7bnljrFO2DNSGwd-0

Updated
Receipt.pdf

@kzdev420 kzdev420 requested a review from argush3 January 28, 2025 21:22
Copy link
Collaborator

@ArwenQin ArwenQin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kevin!

Copy link
Collaborator

@meawong meawong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once the typo is fixed!

Copy link

@kzdev420 kzdev420 merged commit 48550e2 into bcgov:main Jan 29, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants