Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24772 - Update API Specs and Unit Test Mocks #3178

Merged
merged 3 commits into from
Jan 23, 2025
Merged

24772 - Update API Specs and Unit Test Mocks #3178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fa1c738
24772-Update specs and mocks in unit test
meawong Jan 22, 2025
ea2c8c7
24772-Add-new-properties-to-success-response
meawong Jan 22, 2025
5d204f2
24772-Update titles to reflect changes in schema
meawong Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions docs/business.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -726,6 +726,8 @@ paths:
submitter: 'mocked submitter'
noticeOfWithdrawal:
filingId: 123456
hasTakenEffect: false
partOfPoa: false
voluntary-dissolution-success-response:
summary: Voluntary Dissolution Response
value:
Expand Down Expand Up @@ -1523,6 +1525,8 @@ paths:
courtOrder:
fileNumber: "A12345"
effectOfOrder: planOfArrangement
hasTakenEffect: false
partOfPoa: false
voluntary-dissolution-request:
summary: Voluntary Dissolution Request
value:
Expand Down Expand Up @@ -6355,6 +6359,12 @@ components:
title: ID for the future effective filing
courtOrder:
$ref: '#/components/schemas/Court_order'
hasTakenEffect:
type: boolean
title: One of the terms of arrangement for the FED filing have taken effect
partOfPoa:
type: boolean
title: FED filing is part of a Plan of Arrangement
x-examples:
Example 1:
noticeOfWithdrawal:
Expand Down
5 changes: 2 additions & 3 deletions legal-api/tests/unit/resources/v2/test_business_filings/test_filing_documents.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,12 +141,11 @@ def test_unpaid_filing(session, client, jwt):
ALTERATION_MEMORANDUM_RULES_IN_RESOLUTION['memorandumInResolution'] = True
ALTERATION_MEMORANDUM_RULES_IN_RESOLUTION['rulesInResolution'] = True

# a mock notice of withdrawal filing, since its schema is not ready yet
# may need to delete this and change variables in the test cases in the future
MOCK_NOTICE_OF_WITHDRAWAL = {}
MOCK_NOTICE_OF_WITHDRAWAL['courtOrder'] = copy.deepcopy(COURT_ORDER)
MOCK_NOTICE_OF_WITHDRAWAL['filingId'] = '123456'

MOCK_NOTICE_OF_WITHDRAWAL['hasTakenEffect'] = False
MOCK_NOTICE_OF_WITHDRAWAL['partOfPoa'] = False

@pytest.mark.parametrize('test_name, identifier, entity_type, filing_name_1, legal_filing_1, filing_name_2, legal_filing_2, status, expected_msg, expected_http_code, payment_completion_date', [
('special_res_paper', 'CP7654321', Business.LegalTypes.COOP.value,
Expand Down
Loading