Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24952 - Fix not allow to update NoW draft issue #3139

Merged

Conversation

eason-pan-bc
Copy link
Collaborator

@eason-pan-bc eason-pan-bc commented Dec 19, 2024

Issue #: /bcgov/entity#24952

Description of changes:
Updated the logic for allowable actions to enable update Notice of Withdrawal draft. This change is only within scope for regular/existing businesses. The support of allowable actions for temporary business will be done in bcgov/entity#24987

Issue Before

  • Can file NoW and NoW draft
  • But cannot update the draft using PUT method with endpoint /api/v2/businesses/:identifier/filings/:filing_id?draft=true

After Update

Able to update NoW draft using the endpoint and method mentioned above.

  • Create a Draft
    image
  • Update this Draft
    image

Other Verifications

  • Allowable Actions: there is no NoW or NoW draft, NoW filing is allowed
    image
  • Allowable Action: after a NoW draft is created, NoW filing is not allowed anymore
    image
  • Try to create the second draft when there is already a draft exist is now allowed
    image

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@eason-pan-bc eason-pan-bc self-assigned this Dec 19, 2024
@eason-pan-bc eason-pan-bc marked this pull request as ready for review December 19, 2024 23:16
@eason-pan-bc eason-pan-bc changed the title 24952 - update logic to allow update NoW draft 24952 - Fix not allow to update NoW draft issue Dec 19, 2024
Copy link
Collaborator

@AimeeGao AimeeGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful solutions! LGTM (^-^)

@eason-pan-bc eason-pan-bc merged commit 9edd49d into bcgov:main Dec 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants