Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

23362 Fetch Endpoint for FED Filings #3125

Merged
merged 7 commits into from
Dec 16, 2024
Merged

23362 Fetch Endpoint for FED Filings #3125

merged 7 commits into from
Dec 16, 2024

Conversation

meawong
Copy link
Collaborator

@meawong meawong commented Dec 13, 2024 •
edited
Loading

Issue #: /bcgov/entity#23362

Description of changes:

  • Add new endpoint to fetch a FED filing given a filing ID

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@meawong meawong marked this pull request as ready for review December 13, 2024 02:42
@meawong meawong changed the title 23363 fetch endpoint for fed filings 23362 Fetch Endpoint for FED Filings Dec 13, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

severinbeauvais
severinbeauvais approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but make sure Argus and Vysakh are OK with this.

@meawong meawong merged commit d9d8a35 into bcgov:main Dec 16, 2024
8 checks passed
@meawong meawong deleted the 23363-Fetch-Endpoint-for-FED-Filings branch January 7, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@severinbeauvais severinbeauvais severinbeauvais approved these changes

@eason-pan-bc eason-pan-bc eason-pan-bc left review comments

@vysakh-menon-aot vysakh-menon-aot vysakh-menon-aot approved these changes

@ArwenQin ArwenQin Awaiting requested review from ArwenQin

@ketaki-deodhar ketaki-deodhar Awaiting requested review from ketaki-deodhar

Assignees

@meawong meawong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@meawong @severinbeauvais @vysakh-menon-aot @eason-pan-bc @ketaki-deodhar